Hi Leif,

We do not use this file and am ok if this is removed. However, I will let 
Thomas confirm this.

Regards,

Sami Mujawar

-----Original Message-----
From: Leif Lindholm <[email protected]> 
Sent: 07 May 2019 10:31 AM
To: Fan, ZhijuX <[email protected]>
Cc: [email protected]; Thomas Abraham <[email protected]>; Sami Mujawar 
<[email protected]>; Cohen, Eugene <[email protected]>
Subject: Re: [PATCH 3/3] ArmPlatformPkg:Delete FrameworkDatabase from 
ArmPlatformPkg

On Mon, May 06, 2019 at 09:20:12AM +0000, Fan, ZhijuX wrote:
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1627
> 
> The FrameworkDatabase was already obsolete, So, FrameworkDatabase can 
> be removed from ArmPlatformPkg.
> 
> This patch is going to fix this issue.
> 
> Cc: Leif Lindholm <[email protected]>
> Cc: Ard Biesheuvel <[email protected]>
> Signed-off-by: Zhiju.Fan <[email protected]>

So, first of all:
Reviewed-by: Leif Lindholm <[email protected]>

Hmm. I wonder if anyone actually uses this Makefile at all since we moved the 
platforms out. Thomas? Sami? Eugene?

Best Regards,

Leif

> ---
>  ArmPlatformPkg/Scripts/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ArmPlatformPkg/Scripts/Makefile 
> b/ArmPlatformPkg/Scripts/Makefile index 09f1c90923..76f25e35e8 100644
> --- a/ArmPlatformPkg/Scripts/Makefile
> +++ b/ArmPlatformPkg/Scripts/Makefile
> @@ -65,7 +65,6 @@ endif
>  $(EDK2_CONF):
>  ifeq ("$(OS)","Windows_NT")
>       copy $(EDK_TOOLS_PATH)\Conf\build_rule.template Conf\build_rule.txt
> -     copy $(EDK_TOOLS_PATH)\Conf\FrameworkDatabase.template 
> Conf\FrameworkDatabase.txt
>       copy $(EDK_TOOLS_PATH)\Conf\target.template Conf\target.txt
>       copy $(EDK_TOOLS_PATH)\Conf\tools_def.template Conf\tools_def.txt
> else
> --
> 2.14.1.windows.1
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40098): https://edk2.groups.io/g/devel/message/40098
Mute This Topic: https://groups.io/mt/31518094/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to