Hi Thomas, On Wed, May 08, 2019 at 06:11:18AM +0000, Thomas Abraham wrote: > > We do not use this file and am ok if this is removed. However, I will let > > Thomas confirm this. > > This makefile is not used for ARM platforms (FVP, Juno, SGI, RD) and so > this makefile can be removed.
Excellent, thanks. Could I be awkward enough to ask you to send a patch to do so, since Ard is out this week and I don't review my own patches? Regards, Leif > Thanks, > Thomas. > > > > > Regards, > > > > Sami Mujawar > > > > -----Original Message----- > > From: Leif Lindholm <leif.lindh...@linaro.org> > > Sent: 07 May 2019 10:31 AM > > To: Fan, ZhijuX <zhijux....@intel.com> > > Cc: devel@edk2.groups.io; Thomas Abraham <thomas.abra...@arm.com>; Sami > > Mujawar <sami.muja...@arm.com>; Cohen, Eugene <eug...@hp.com> > > Subject: Re: [PATCH 3/3] ArmPlatformPkg:Delete FrameworkDatabase from > > ArmPlatformPkg > > > > On Mon, May 06, 2019 at 09:20:12AM +0000, Fan, ZhijuX wrote: > >> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1627 > >> > >> The FrameworkDatabase was already obsolete, So, FrameworkDatabase can > >> be removed from ArmPlatformPkg. > >> > >> This patch is going to fix this issue. > >> > >> Cc: Leif Lindholm <leif.lindh...@linaro.org> > >> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > >> Signed-off-by: Zhiju.Fan <zhijux....@intel.com> > > > > So, first of all: > > Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > > > > Hmm. I wonder if anyone actually uses this Makefile at all since we moved > > the platforms out. Thomas? Sami? Eugene? > > > > Best Regards, > > > > Leif > > > >> --- > >> ArmPlatformPkg/Scripts/Makefile | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/ArmPlatformPkg/Scripts/Makefile > >> b/ArmPlatformPkg/Scripts/Makefile index 09f1c90923..76f25e35e8 100644 > >> --- a/ArmPlatformPkg/Scripts/Makefile > >> +++ b/ArmPlatformPkg/Scripts/Makefile > >> @@ -65,7 +65,6 @@ endif > >> $(EDK2_CONF): > >> ifeq ("$(OS)","Windows_NT") > >> copy $(EDK_TOOLS_PATH)\Conf\build_rule.template Conf\build_rule.txt > >> -copy $(EDK_TOOLS_PATH)\Conf\FrameworkDatabase.template > >> Conf\FrameworkDatabase.txt > >> copy $(EDK_TOOLS_PATH)\Conf\target.template Conf\target.txt > >> copy $(EDK_TOOLS_PATH)\Conf\tools_def.template Conf\tools_def.txt > >> else > >> -- > >> 2.14.1.windows.1 > >> > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40187): https://edk2.groups.io/g/devel/message/40187 Mute This Topic: https://groups.io/mt/31518094/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
