Rebecca: The change is good. Reviewed-by: Liming Gao <liming....@intel.com> for 1-4, and 6.
For patch 5, I see Leif sends another version update. I will give the comments on his change. Thanks Liming > -----Original Message----- > From: Rebecca Cran [mailto:rebe...@bsdio.com] > Sent: Wednesday, July 17, 2019 12:56 AM > To: devel@edk2.groups.io; ler...@redhat.com; Feng, Bob C > <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com>; Kinney, > Michael D <michael.d.kin...@intel.com>; af...@apple.com; Fan, ZhijuX > <zhijux....@intel.com>; leif.lindh...@linaro.org > Cc: Rebecca Cran <rebe...@bsdio.com> > Subject: [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of > executing pwd command > > This is a (very minor) optimization: `pwd` runs the command (even as a > built-in), whereas $PWD simply evaluates the value of the variable. > > ALso, modern scripts should generally use $(...) to run commands, > instead of `...`. > > Signed-off-by: Rebecca Cran <rebe...@bsdio.com> > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > edksetup.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/edksetup.sh b/edksetup.sh > index 12a3e26a67..ab58fe4a6e 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -71,7 +71,7 @@ function SetWorkspace() > # > # Set $WORKSPACE > # > - export WORKSPACE=`pwd` > + export WORKSPACE=$PWD > return 0 > } > > -- > 2.22.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43834): https://edk2.groups.io/g/devel/message/43834 Mute This Topic: https://groups.io/mt/32493796/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
