Hi All, On 07/16/19 18:55, rebe...@bsdio.com wrote: > This is a (very minor) optimization: `pwd` runs the command (even as a > built-in), whereas $PWD simply evaluates the value of the variable. > > ALso, modern scripts should generally use $(...) to run commands, > instead of `...`. > > Signed-off-by: Rebecca Cran <rebe...@bsdio.com> > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > edksetup.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/edksetup.sh b/edksetup.sh > index 12a3e26a67..ab58fe4a6e 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -71,7 +71,7 @@ function SetWorkspace() > # > # Set $WORKSPACE > # > - export WORKSPACE=`pwd` > + export WORKSPACE=$PWD > return 0 > } > >
should we push patches #1 through #4 from this series? They are independent of python detection (which is still being discussed). Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44160): https://edk2.groups.io/g/devel/message/44160 Mute This Topic: https://groups.io/mt/32493796/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
