Bob: I have no comments for this patch set. I am OK to add it for 201908 stable tag. Ack-by: Liming Gao <liming....@intel.com>
Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Friday, August 9, 2019 7:29 AM > To: Feng, Bob C <bob.c.f...@intel.com>; devel@edk2.groups.io; > leif.lindh...@linaro.org > Cc: Andrew Fish <af...@apple.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen > > On 08/09/19 00:18, Laszlo Ersek wrote: > > On 08/08/19 17:38, Feng, Bob C wrote: > >> Hi Laszlo and Leif, > >> > >> Thanks for you detailed testing and comments. > >> > >> I'd like to explain the failure of the test 3#. I can reproduce the > >> failure with your steps and I found this failure can also be reproduced > without multiple process autogen patch set. I debugged and found this > failure is due to --hash build option. I double tested that if > remove --hash build option, the test 3# can pass. Would you please double > verified test 3# without --hash? > >> > >> I think we can enter a new BZ for the --hash bug. > > > > Confirmed -- with "--hash" removed from the build command line, the build > > is picked up fine after Ctrl-C. (And the firmware binary is > sound.) > > > > So, my ACK stands. > > > > ( > > > > And now I remember that in my v3 testing, I also omitted "--hash": > > > > > > 4ea3d3fa-2210-3642-2337-db525312d312@redhat.com">http://mid.mail-archive.com/4ea3d3fa-2210-3642-2337-db525312d312@redhat.com > > https://edk2.groups.io/g/devel/message/44246 > > > > At the bottom I stated that I didn't test "--hash". > > > > ) > > ... based on the above, I can even provide: > > Tested-by: Laszlo Ersek <ler...@redhat.com> > > for the series. > > Thanks > Laszlo > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45249): https://edk2.groups.io/g/devel/message/45249 Mute This Topic: https://groups.io/mt/32779325/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
