Leif: > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, September 17, 2019 5:15 PM > To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zh...@intel.com> > Cc: ard.biesheu...@linaro.org; Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao > A <hao.a...@intel.com>; Ni, Ray <ray...@intel.com>; > Laszlo Ersek <ler...@redhat.com>; Gao, Liming <liming....@intel.com>; Gao, > Zhichao <zhichao....@intel.com> > Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend > the support terminal types > > On Tue, Sep 17, 2019 at 07:17:27AM +0000, Zhang, Shenglei wrote: > > That's my mistake to push the broken > > patch(0d85e67714e31e0dbe4241ab2ebb7c423aba174d). > > This patch only updates the file guid, which I thought has no risk. So I > > didn’t check the build result. > > I should double check the new guid used in the file. > > Determining what affects build and not is something humans are very > bad at and computers are very good at. > > So you should build check every patch you submit to the list, no > matter how trivial. > > In normal circumstances, so should the maintainers before pushing the > patch.
I push this change. I should double confirm its test result. I will improve my rule. > > We now have a commit in the tree known to break the build of pretty > much all ARM/AARCH64 platforms. This will be very unpleasant for > future bisect. I agree the build break is the big impact. I expect we can speed up to enable EDK II Continuous Integration. If so, we can avoid such break again. Thanks Liming > > Best Regards, > > Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47376): https://edk2.groups.io/g/devel/message/47376 Mute This Topic: https://groups.io/mt/34173528/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
