Thanks Michael. Another thing we should consider doing a some point in the future is moving the PlatformSecLib implementation that supports dispatch mode from KabylakeOpenBoardPkg to MinPlatformPkg.
-----Original Message----- From: Kubacki, Michael A <michael.a.kuba...@intel.com> Sent: Wednesday, October 2, 2019 6:35 PM To: devel@edk2.groups.io; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> Cc: Chiu, Chasel <chasel.c...@intel.com>; Jeremy Soller <jer...@system76.com> Subject: RE: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Wrong instance of PlatformSecLib is used. Reviewed-by: Michael Kubacki <michael.a.kuba...@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate > DeSimone > Sent: Wednesday, October 2, 2019 12:41 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Kubacki, Michael A > <michael.a.kuba...@intel.com>; Jeremy Soller <jer...@system76.com> > Subject: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: > Wrong instance of PlatformSecLib is used. > > The GalagoPro3 platform in KabylakeOpenBoardPkg is using the instance > of PlatformSecLib in MinPlatformPkg instead of the instance in > KabylakeOpenBoardPkg. The version in MinPlatformPkg does not support > FSP 2.1 Dispatch Mode, whearas the version in KabylakeOpenBoardPkg does. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Michael Kubacki <michael.a.kuba...@intel.com> > Cc: Jeremy Soller <jer...@system76.com> > Signed-off-by: Nate DeSimone <nathaniel.l.desim...@intel.com> > --- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index d67e0cc000..f3dd2b0c91 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -85,7 +85,7 @@ > > PlatformHookLib|$(PROJECT)/Library/BasePlatformHookLib/BasePlatformHo > okLib.inf > FspWrapperHobProcessLib|$(PLATFORM_PACKAGE)/FspWrapper/Library/P > eiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf- > PlatformSecLib|$(PLATFORM_PACKAGE)/FspWrapper/Library/SecFspWrapp > erPlatformSecLib/SecFspWrapperPlatformSecLib.inf+ > PlatformSecLib|$(PLATFORM_BOARD_PACKAGE)/FspWrapper/Library/SecFs > pWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf > FspWrapperApiLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/Ba > seFspWrapperApiLib.inf > FspWrapperApiTestLib|IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTest > Lib/PeiFspWrapperApiTestLib.inf-- > 2.23.0.windows.1 > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#48362): > https://edk2.groups.io/g/devel/message/48362 > Mute This Topic: https://groups.io/mt/34367442/1772268 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.a.kuba...@intel.com] -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48413): https://edk2.groups.io/g/devel/message/48413 Mute This Topic: https://groups.io/mt/34367442/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
