Good catch, thank you! -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Philippe Mathieu-Daudé Sent: Thursday, October 3, 2019 12:40 AM To: devel@edk2.groups.io; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> Cc: Chiu, Chasel <chasel.c...@intel.com>; Kubacki, Michael A <michael.a.kuba...@intel.com>; Jeremy Soller <jer...@system76.com> Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Wrong instance of PlatformSecLib is used.
On 10/2/19 9:40 AM, Nate DeSimone wrote: > The GalagoPro3 platform in KabylakeOpenBoardPkg is using the instance > of PlatformSecLib in MinPlatformPkg instead of the instance in > KabylakeOpenBoardPkg. The version in MinPlatformPkg does not support > FSP 2.1 Dispatch Mode, whearas the version in typo: "whereas" > KabylakeOpenBoardPkg does. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Michael Kubacki <michael.a.kuba...@intel.com> > Cc: Jeremy Soller <jer...@system76.com> > Signed-off-by: Nate DeSimone <nathaniel.l.desim...@intel.com> > --- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index d67e0cc000..f3dd2b0c91 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -85,7 +85,7 @@ > > PlatformHookLib|$(PROJECT)/Library/BasePlatformHookLib/BasePlatformHoo > kLib.inf > > > FspWrapperHobProcessLib|$(PLATFORM_PACKAGE)/FspWrapper/Library/PeiFspW > rapperHobProcessLib/PeiFspWrapperHobProcessLib.inf > - > PlatformSecLib|$(PLATFORM_PACKAGE)/FspWrapper/Library/SecFspWrapperPla > tformSecLib/SecFspWrapperPlatformSecLib.inf > + > + PlatformSecLib|$(PLATFORM_BOARD_PACKAGE)/FspWrapper/Library/SecFspWr > + apperPlatformSecLib/SecFspWrapperPlatformSecLib.inf > > > FspWrapperApiLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/BaseFspWrapperApiLib.inf > > FspWrapperApiTestLib|IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestL > ib/PeiFspWrapperApiTestLib.inf > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48414): https://edk2.groups.io/g/devel/message/48414 Mute This Topic: https://groups.io/mt/34367442/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
