Thanks Ashraf > -----Original Message----- > From: Ni, Ray <ray...@intel.com> > Sent: Monday, February 10, 2020 1:07 PM > To: Javeed, Ashraf <ashraf.jav...@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com> > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 02/12] > MdeModulePkg/PciBusDxe: Setup PCI Express init phase > > > > + Status = EnumeratePciExpressFeatures ( > 1. "enumerate" means "visit". But I think this function is not just visiting > the > features but also > programming them. So, How about "ProgramPciExpressFeatures"? > (I gave a similar review comment in last time review in Dec.) > Actually I have already used the "ProgramPciExpressFeatures" in one of the sub-phases of the PCI Express initialization code...do you have any other name for this? How about "ConfigurePciExpressFeatures"?
> 2. In mail https://edk2.groups.io/g/devel/message/52399 I proposed to simplify > to 4 phases. > Did you find any issue with my proposal? I did simplify to 4 phases, please check. The fifth phase is to report out the device state to the platform through the protocol interface "NotifyDeviceState". > > Thanks, > Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54117): https://edk2.groups.io/g/devel/message/54117 Mute This Topic: https://groups.io/mt/71063383/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
