Reviewed-by: Bret Barkelew <bret.barke...@microsoft.com> - Bret
________________________________ From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of GuoMinJ via Groups.Io <newexplorerj=gmail....@groups.io> Sent: Wednesday, February 19, 2020 5:41:56 PM To: devel@edk2.groups.io <devel@edk2.groups.io> Cc: GuoMinJ <newexplor...@gmail.com> Subject: [EXTERNAL] [edk2-devel] [PATCH] UnitTestFrameworkPkg: Invalid index may be used. REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2535&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C49deda8899264bfbb32108d7b5a66f87%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637177598752484898&sdata=WySGg%2BbeLnDDt98xRUOhjGd1DkNyU5m8HiRInsVKm4Q%3D&reserved=0 The UINT_TEST_STATUS and FAILURE_TYPE have used 0 as status, so use 0 as unknown is confused, remove it from array enumeration but keep it location in the array. Signed-off-by: GuoMinJ <newexplor...@gmail.com> --- .../Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c index 687a04f55d..eba68e330c 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c @@ -65,7 +65,7 @@ GetStringForUnitTestStatus ( { UINTN Index; - for (Index = 0; Index < ARRAY_SIZE (mStatusStrings); Index++) { + for (Index = 0; Index < ARRAY_SIZE (mStatusStrings) - 1; Index++) { if (mStatusStrings[Index].Status == Status) { // // Return string from matching entry @@ -87,7 +87,7 @@ GetStringForFailureType ( { UINTN Index; - for (Index = 0; Index < ARRAY_SIZE (mFailureTypeStrings); Index++) { + for (Index = 0; Index < ARRAY_SIZE (mFailureTypeStrings) - 1; Index++) { if (mFailureTypeStrings[Index].Type == Failure) { // // Return string from matching entry -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54685): https://edk2.groups.io/g/devel/message/54685 Mute This Topic: https://groups.io/mt/71438622/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
