Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> Mike
> -----Original Message----- > From: Jiang, Guomin <guomin.ji...@intel.com> > Sent: Sunday, March 22, 2020 10:56 PM > To: devel@edk2.groups.io; Zhang, Shenglei > <shenglei.zh...@intel.com>; newexplor...@gmail.com > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; > sean.bro...@microsoft.com; bret.barke...@microsoft.com > Subject: RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg: > Invalid index may be used. > > Hi Michael, Sean, Bret, > > Could help review the patch? > > Thanks > > -----Original Message----- > > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of > > Zhang, Shenglei > > Sent: Wednesday, March 4, 2020 3:59 PM > > To: devel@edk2.groups.io; newexplor...@gmail.com > > Subject: Re: [edk2-devel] [PATCH] > UnitTestFrameworkPkg: Invalid index may > > be used. > > > > Reviewed-by: Shenglei Zhang > <shenglei.zh...@intel.com> > > > > > -----Original Message----- > > > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of > > > GuoMinJ > > > Sent: Thursday, February 20, 2020 9:42 AM > > > To: devel@edk2.groups.io > > > Cc: GuoMinJ <newexplor...@gmail.com> > > > Subject: [edk2-devel] [PATCH] UnitTestFrameworkPkg: > Invalid index may > > > be used. > > > > > > REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=2535 > > > > > > The UINT_TEST_STATUS and FAILURE_TYPE have used 0 > as status, so use 0 > > > as unknown is confused, remove it from array > enumeration but keep it > > > location in the array. > > > > > > Signed-off-by: GuoMinJ <newexplor...@gmail.com> > > > --- > > > > .../Library/UnitTestResultReportLib/UnitTestResultRepor > tLib.c | 4 > > > ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git > > > > > > a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/ > UnitTestResultR > > > eportLib.c > > > > > > b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/ > UnitTestResultR > > > eportLib.c > > > index 687a04f55d..eba68e330c 100644 > > > --- > > > > > > a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/ > UnitTestResultR > > > eportLib.c > > > +++ > > > > > > b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/ > UnitTestResultR > > > eportLib.c > > > @@ -65,7 +65,7 @@ GetStringForUnitTestStatus ( { > > > UINTN Index; > > > > > > - for (Index = 0; Index < ARRAY_SIZE > (mStatusStrings); Index++) { > > > + for (Index = 0; Index < ARRAY_SIZE > (mStatusStrings) - 1; Index++) { > > > if (mStatusStrings[Index].Status == Status) { > > > // > > > // Return string from matching entry @@ - > 87,7 +87,7 @@ > > > GetStringForFailureType ( { > > > UINTN Index; > > > > > > - for (Index = 0; Index < ARRAY_SIZE > (mFailureTypeStrings); Index++) > > > { > > > + for (Index = 0; Index < ARRAY_SIZE > (mFailureTypeStrings) - 1; > > > + Index++) { > > > if (mFailureTypeStrings[Index].Type == > Failure) { > > > // > > > // Return string from matching entry > > > -- > > > 2.17.1 > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56113): https://edk2.groups.io/g/devel/message/56113 Mute This Topic: https://groups.io/mt/71411719/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
