On 03/09/20 20:29, Laszlo Ersek wrote: > Hi Mike, > > On 03/08/20 20:53, Kinney, Michael D wrote: >> I added the @Mergifyio refresh to these PRs. >> >> This one was merged: >> https://github.com/tianocore/edk2/pull/427 >> >> This one is failing PatchCheck with a missing Signed-off-by >> https://github.com/tianocore/edk2/pull/430 >> >> This one needs to be rebased and resubmitted >> https://github.com/tianocore/edk2/pull/428 > > Thanks for kicking mergify. > > I think maintainers should have permission to kick mergify (if they > don't have that permission already). Otherwise, the automated > merge-on-CI-pass is not actually automated, and we create a bottleneck > in an otherwise distributed / asynchronous workflow. If only you can > kick mergify, then any *valid* (CI-clean) pull request will potentially > have to wait on you. > > Mergify kicking rights do not allow maintainers to bypass CI checks, if > I understand correctly. (Unlike direct merge / repository write access.) > > BTW I didn't even know about this mergify "command". Is there a guide > somewhere? > > I honestly feel this should have been handled / introduced more > transparently. I rarely feel as powerless as with PR#428. CI passed, the > PR was stuck, github didn't respond to my ticket, mergify.io didn't > respond to my ticket, and the PR was actually urgent (fixing a build > breakage). I was sitting there uncomfortably as one of the stewards, > unable to fix the situation. Earlier all this would take was a git-push > command.
Yup, just seen this too: "@lersek is not allowed to run commands" :/ -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55693): https://edk2.groups.io/g/devel/message/55693 Mute This Topic: https://groups.io/mt/53725670/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
