I’ll play with it a little and see if the pipelines/documentation needs to change. Thanks!
- Bret ________________________________ From: Kinney, Michael D <michael.d.kin...@intel.com> Sent: Thursday, April 23, 2020 10:26:32 AM To: devel@edk2.groups.io <devel@edk2.groups.io>; Bret Barkelew <bret.barke...@microsoft.com>; navdeeppal.si...@dell.com <navdeeppal.si...@dell.com>; Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup Bret, I wonder if this is an order of operations issue. Those 2 commits convert Brotli support to submodules. One for the FW decompress lib, and the other for the compression tool. The patch adds both submodule links to CISettings.py and we know that works for FW components. However, this may be the first time it is used for a C tool in BaseTools. In order for BaseTool/EDK2ToolsBuild.py to complete, all the sources need to be present. So does CISettings.py need to be processed before running BaseTool/EDK2ToolsBuild.py? Mike From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bret Barkelew via groups.io Sent: Thursday, April 23, 2020 9:34 AM To: navdeeppal.si...@dell.com; devel@edk2.groups.io; Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com> Subject: Re: [EXTERNAL] [edk2-devel] EDK2 environment setup Confirmed that it seems related to these two commits: https://github.com/tianocore/edk2/commit/58802e02c41bd715a5d3586f4bf2a4b1c46e9274<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fcommit%2F58802e02c41bd715a5d3586f4bf2a4b1c46e9274&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C766c0b1bef7145e0acd208d7e7ab8f7a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637232596365128994&sdata=2VhPZnY3MDipJb7E4PhnTCFu7a0cpZfhr0KjjyN1FU0%3D&reserved=0> https://github.com/tianocore/edk2/commit/06033f5abad3815e8d80de22c97ba38a05017262<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fcommit%2F06033f5abad3815e8d80de22c97ba38a05017262&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C766c0b1bef7145e0acd208d7e7ab8f7a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637232596365138987&sdata=crxrT6K7r3uiTfSLXH2BRHyIT1tOgcswd1E77yliQ0U%3D&reserved=0> If I roll back to the commit prior, the Tools build works. Anyone involved in BaseTools have an idea? @Feng, Bob C<mailto:bob.c.f...@intel.com> or @Liming Gao<mailto:liming....@intel.com>? - Bret From: navdeeppal.si...@dell.com<mailto:navdeeppal.si...@dell.com> Sent: Thursday, April 23, 2020 9:21 AM To: Bret Barkelew<mailto:bret.barke...@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup I will roll back to 202002 stable tag and try. Thank you Navdeep From: Bret Barkelew <bret.barke...@microsoft.com<mailto:bret.barke...@microsoft.com>> Sent: Thursday, April 23, 2020 9:48 PM To: Singh, Navdeeppal; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup [EXTERNAL EMAIL] Yeah, I was noticing some problems with BrotliCompress the other day. Seems like a relatively recent change. I know the 202002 stable tag was fine. I’ll try to dig into this a bit. Thanks for bring it to our attention! - Bret From: navdeeppal.si...@dell.com<mailto:navdeeppal.si...@dell.com> Sent: Thursday, April 23, 2020 9:14 AM To: Bret Barkelew<mailto:bret.barke...@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup Hi Bret, Yes PIP requirements are up to date. On further digging through the logging file BASETOOLS_BUILD.txt. INFO - subprocess not exit successfully INFO - Error while execute command 'nmake all' in direcotry C:\edk2\BaseTools\Source\C\BrotliCompress Regards, Navdeep From: Bret Barkelew <bret.barke...@microsoft.com<mailto:bret.barke...@microsoft.com>> Sent: Thursday, April 23, 2020 9:37 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Singh, Navdeeppal Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup [EXTERNAL EMAIL] Have you installed the up-to-date Python requirements? “pip install –upgrade -r pip-requirements.txt”? That’s the first thing I would check. Otherwise, happy to look at the problem with you. - Bret From: NAVDEEPPAL_SINGH via groups.io<mailto:NAVDEEPPAL_SINGH=dell....@groups.io> Sent: Thursday, April 23, 2020 6:05 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: [EXTERNAL] [edk2-devel] EDK2 environment setup I am trying to setup EDK2 environment setup from Tianocore/EDK2. While doing the Base Tool setup. After running BaseTool/EDK2ToolsBuild.py -t VS2019 Getting following error :- c:\edk2\BaseTools>python Edk2ToolsBuild.py -t VS2019 SECTION - Init SDE SECTION - Loading Plugins SECTION - Start Invocable Tool Traceback (most recent call last): File "Edk2ToolsBuild.py", line 177, in <module> main() File "Edk2ToolsBuild.py", line 173, in main Edk2ToolsBuild().Invoke() File "C:\Program Files\Python38\lib\site-packages\edk2toolext\base_abstract_invocable.py", line 141, in Invoke retcode = self.Go() File "Edk2ToolsBuild.py", line 139, in Go raise Exception("Failed to build.") Exception: Failed to build. set EDK_TOOLS_PATH=C:\edk2\BaseTools set EDK_TOOLS_BIN=C:\edk2\BaseTools\Bin\Win32 Can some one help -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57990): https://edk2.groups.io/g/devel/message/57990 Mute This Topic: https://groups.io/mt/73221997/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
