Having only ever used PRs, what does that mean? He should have copied the “R-b” text and amended that commit message in this version?
- Bret ________________________________ From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Laszlo Ersek via groups.io <lersek=redhat....@groups.io> Sent: Wednesday, May 13, 2020 4:07:34 AM To: devel@edk2.groups.io <devel@edk2.groups.io>; chept...@ispras.ru <chept...@ispras.ru> Cc: Dong, Eric <eric.d...@intel.com>; Ni, Ray <ray...@intel.com> Subject: [EXTERNAL] Re: [edk2-devel] [PATCH V5 24/27] UefiCpuPkg: Add support for DebugCommonLib On 05/12/20 19:02, Vitaly Cheptsov wrote: > REF: > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2054&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cc382255c73964cb091ed08d7f72ddd70%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637249648679637664&sdata=uE8hQ1goSvrnyjx8orh6l3%2BuS%2BzlOpZtXZylsEEzHBo%3D&reserved=0 > > CC: Eric Dong <eric.d...@intel.com> > CC: Ray Ni <ray...@intel.com> > CC: Laszlo Ersek <ler...@redhat.com> > Signed-off-by: Vitaly Cheptsov <vit9...@protonmail.com> > --- > UefiCpuPkg/UefiCpuPkg.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index d28cb5cccb..f5f407ad23 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dsc > +++ b/UefiCpuPkg/UefiCpuPkg.dsc > @@ -27,6 +27,7 @@ [LibraryClasses] > CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf > + DebugCommonLib|MdePkg/Library/BaseDebugCommonLib/BaseDebugCommonLib.inf > > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > Again, identical to the v4 counterpart. Should have picked up my R-b. https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmid.mail-archive.com%2F0d0b6b6f-39c8-4056-c496-07151e33cdd5%40redhat.com&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cc382255c73964cb091ed08d7f72ddd70%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637249648679637664&sdata=X%2Bvi9LqaswphH3DM63JWIK2UJP8%2B%2BxDOBEkmDCF6%2FPw%3D&reserved=0 https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F59202&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cc382255c73964cb091ed08d7f72ddd70%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637249648679637664&sdata=ECkvl%2FeXKWbud%2FsNB2%2BusXff9HY%2F7OWx%2FFD5DejhC3c%3D&reserved=0 anyway Reviewed-by: Laszlo Ersek <ler...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59437): https://edk2.groups.io/g/devel/message/59437 Mute This Topic: https://groups.io/mt/74183165/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
