Hi Laszlo, Actually it does matter. The proposed new code review process does not change the commit message requirements.
The tools/methods to produce correct commit message contents are still very valuable. There may be opportunities to automate some of these steps, but that is captured in Future Enhancements section of the RFC. Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On > Behalf Of Laszlo Ersek > Sent: Wednesday, May 13, 2020 8:53 AM > To: devel@edk2.groups.io; bret.barke...@microsoft.com; > chept...@ispras.ru > Cc: Dong, Eric <eric.d...@intel.com>; Ni, Ray > <ray...@intel.com> > Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH V5 > 24/27] UefiCpuPkg: Add support for DebugCommonLib > > On 05/13/20 16:43, Bret Barkelew via groups.io wrote: > > Having only ever used PRs, what does that mean? He > should have copied the “R-b� text and > amended that commit message in this version? > > ... not that it matters much at this point (as we're > transitioning to > github.com-based reviews), but (just for the record) I > explained it in > my "unkempt git guide", in step#28 of the "Contributor > workflow": > > https://github.com/tianocore/tianocore.github.io/wiki/L > aszlo's-unkempt-git-guide-for-edk2-contributors-and- > maintainers#contrib-28 > > Thanks > Laszlo > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59443): https://edk2.groups.io/g/devel/message/59443 Mute This Topic: https://groups.io/mt/74183165/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
