On Sat, Feb 20, 2021 at 20:28:58 -0700, Rebecca Cran wrote:
> The return type should be on the line before any EFIAPI specifier.
> 
> Signed-off-by: Rebecca Cran <rebe...@nuviainc.com>

Reviewed-by: Leif Lindholm <l...@nuviainc.com>

> ---
>  ArmPkg/Include/Library/OemMiscLib.h                 | 14 +++++++-------
>  ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 12 ++++++------
>  2 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/ArmPkg/Include/Library/OemMiscLib.h 
> b/ArmPkg/Include/Library/OemMiscLib.h
> index e70019d05f15..ad0e77685dbe 100644
> --- a/ArmPkg/Include/Library/OemMiscLib.h
> +++ b/ArmPkg/Include/Library/OemMiscLib.h
> @@ -71,8 +71,8 @@ typedef enum
>  
>    @return               CPU frequency in Hz
>  **/
> -EFIAPI
>  UINTN
> +EFIAPI
>  OemGetCpuFreq (
>    IN UINT8 ProcessorIndex
>    );
> @@ -87,8 +87,8 @@ OemGetCpuFreq (
>  
>    @return  TRUE on success, FALSE on failure.
>  **/
> -EFIAPI
>  BOOLEAN
> +EFIAPI
>  OemGetProcessorInformation (
>    IN UINTN ProcessorIndex,
>    IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus,
> @@ -106,8 +106,8 @@ OemGetProcessorInformation (
>  
>    @return TRUE on success, FALSE on failure.
>  **/
> -EFIAPI
>  BOOLEAN
> +EFIAPI
>  OemGetCacheInformation (
>    IN UINT8   ProcessorIndex,
>    IN UINT8   CacheLevel,
> @@ -120,8 +120,8 @@ OemGetCacheInformation (
>  
>    @return The maximum number of sockets.
>  **/
> -EFIAPI
>  UINT8
> +EFIAPI
>  OemGetProcessorMaxSockets (
>    VOID
>    );
> @@ -132,8 +132,8 @@ OemGetProcessorMaxSockets (
>  
>    @retval EFI_SUCCESS The chassis type was fetched successfully.
>  **/
> -EFIAPI
>  EFI_STATUS
> +EFIAPI
>  OemGetChassisType (
>    OUT UINT8 *ChassisType
>    );
> @@ -144,8 +144,8 @@ OemGetChassisType (
>  
>    @return TRUE is the processor is present, FALSE otherwise.
>  **/
> -EFIAPI
>  BOOLEAN
> +EFIAPI
>  OemIsSocketPresent (
>    IN UINTN ProcessorIndex
>    );
> @@ -156,8 +156,8 @@ OemIsSocketPresent (
>    @param TokenToUpdate The string to update.
>    @param Offset        The field to get information about.
>  **/
> -EFIAPI
>  VOID
> +EFIAPI
>  OemUpdateSmbiosInfo (
>    IN EFI_HII_HANDLE    HiiHandle,
>    IN EFI_STRING_ID     TokenToUpdate,
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c 
> b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> index 73cebef2d1b9..6b179941e414 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> @@ -23,8 +23,8 @@
>  
>    @return               CPU frequency in Hz
>  **/
> -EFIAPI
>  UINTN
> +EFIAPI
>  OemGetCpuFreq (
>    IN UINT8 ProcessorIndex
>    )
> @@ -43,8 +43,8 @@ OemGetCpuFreq (
>  
>    @return  TRUE on success, FALSE on failure.
>  **/
> -EFIAPI
>  BOOLEAN
> +EFIAPI
>  OemGetProcessorInformation (
>    IN UINTN ProcessorIndex,
>    IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus,
> @@ -66,8 +66,8 @@ OemGetProcessorInformation (
>  
>    @return TRUE on success, FALSE on failure.
>  **/
> -EFIAPI
>  BOOLEAN
> +EFIAPI
>  OemGetCacheInformation (
>    IN UINT8   ProcessorIndex,
>    IN UINT8   CacheLevel,
> @@ -84,8 +84,8 @@ OemGetCacheInformation (
>  
>    @return The maximum number of sockets.
>  **/
> -EFIAPI
>  UINT8
> +EFIAPI
>  OemGetProcessorMaxSockets (
>    VOID
>    )
> @@ -117,8 +117,8 @@ OemGetChassisType (
>  
>    @return TRUE is the processor is present, FALSE otherwise.
>  **/
> -EFIAPI
>  BOOLEAN
> +EFIAPI
>  OemIsSocketPresent (
>    IN UINTN ProcessorIndex
>    )
> @@ -133,8 +133,8 @@ OemIsSocketPresent (
>    @param TokenToUpdate The string to update.
>    @param Offset        The field to get information about.
>  **/
> -EFIAPI
>  VOID
> +EFIAPI
>  OemUpdateSmbiosInfo (
>    IN EFI_HII_HANDLE mHiiHandle,
>    IN EFI_STRING_ID TokenToUpdate,
> -- 
> 2.26.2
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71897): https://edk2.groups.io/g/devel/message/71897
Mute This Topic: https://groups.io/mt/80794228/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to