Christopher: Based on current information, I am OK for this change. Reviewed-by: Liming Gao <[email protected]>
Thanks Liming > -----邮件原件----- > 发件人: [email protected] <[email protected]> 代表 Christopher > Zurcher > 发送时间: 2021年7月21日 9:15 > 收件人: [email protected]; [email protected] > 抄送: 'Ard Biesheuvel' <[email protected]>; 'Bob Feng' <[email protected]> > 主题: Re: [edk2-devel] 回复: [PATCH v7 1/3] BaseTools: Remove COMMON > section from the GCC discard list > > Yes, this was verified with OVMF. > > Thanks, > Christopher Zurcher > > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of gaoliming > Sent: Tuesday, July 20, 2021 18:12 > To: [email protected]; [email protected] > Cc: 'Ard Biesheuvel' <[email protected]>; 'Bob Feng' <[email protected]> > Subject: [edk2-devel] 回复: [PATCH v7 1/3] BaseTools: Remove COMMON > section from the GCC discard list > > Christopher: > Thanks for your update. Can you let me know which platform is verified > with this change by GCC tool chain? Ovmf? > > Thanks > Liming > > -----邮件原件----- > > 发件人: [email protected] > > <[email protected]> > > 发送时间: 2021年7月21日 6:07 > > 收件人: [email protected] > > 抄送: Ard Biesheuvel <[email protected]>; Bob Feng > <[email protected]>; > > Liming Gao <[email protected]> > > 主题: [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC > > discard list > > > > From: Christopher Zurcher <[email protected]> > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507 > > > > The COMMON section is used by OpenSSL assembly-optimized crypto > > functions. OpenSSL assembly code is auto-generated from the submodule > > and cannot be modified to remove dependence on the COMMON section. > > The default -fno-common compiler flag should still prevent variable > > from being emitted into the COMMON section. > > > > Cc: Ard Biesheuvel <[email protected]> > > Cc: Bob Feng <[email protected]> > > Cc: Liming Gao <[email protected]> > > Signed-off-by: Christopher Zurcher <[email protected]> > > --- > > BaseTools/Scripts/GccBase.lds | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/BaseTools/Scripts/GccBase.lds > > b/BaseTools/Scripts/GccBase.lds index a9dd2138d4..83cebd29d5 100644 > > --- a/BaseTools/Scripts/GccBase.lds > > +++ b/BaseTools/Scripts/GccBase.lds > > @@ -74,6 +74,5 @@ SECTIONS { > > *(.dynamic) > > *(.hash .gnu.hash) > > *(.comment) > > - *(COMMON) > > } > > } > > -- > > 2.32.0.windows.1 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77998): https://edk2.groups.io/g/devel/message/77998 Mute This Topic: https://groups.io/mt/84348117/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
