On Wed, 21 Jul 2021 at 13:44, Yao, Jiewen <[email protected]> wrote: > > Acked-by: Jiewen Yao <[email protected]> >
I don't think this is a good idea tbh. We have already identified that EDK2 code often fails to use the STATIC keyword when possible for global variables, and that unrelated variables that happen to have the same name will be collapsed into the same storage unit in the program image. (see commit 214a3b79417f64bf2faae74af42c1b9d23f50dc8 for details) Was this considered? Is this no longer an issue? > > -----Original Message----- > > From: [email protected] <[email protected]> On Behalf Of Christopher > > Zurcher > > Sent: Wednesday, July 21, 2021 6:07 AM > > To: [email protected] > > Cc: Ard Biesheuvel <[email protected]>; Feng, Bob C <[email protected]>; > > Liming Gao <[email protected]> > > Subject: [edk2-devel] [PATCH v7 1/3] BaseTools: Remove COMMON section > > from the GCC discard list > > > > From: Christopher Zurcher <[email protected]> > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507 > > > > The COMMON section is used by OpenSSL assembly-optimized crypto > > functions. OpenSSL assembly code is auto-generated from the submodule > > and cannot be modified to remove dependence on the COMMON section. > > The default -fno-common compiler flag should still prevent variable from > > being emitted into the COMMON section. > > > > Cc: Ard Biesheuvel <[email protected]> > > Cc: Bob Feng <[email protected]> > > Cc: Liming Gao <[email protected]> > > Signed-off-by: Christopher Zurcher <[email protected]> > > --- > > BaseTools/Scripts/GccBase.lds | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/BaseTools/Scripts/GccBase.lds b/BaseTools/Scripts/GccBase.lds > > index a9dd2138d4..83cebd29d5 100644 > > --- a/BaseTools/Scripts/GccBase.lds > > +++ b/BaseTools/Scripts/GccBase.lds > > @@ -74,6 +74,5 @@ SECTIONS { > > *(.dynamic) > > *(.hash .gnu.hash) > > *(.comment) > > - *(COMMON) > > } > > } > > -- > > 2.32.0.windows.1 > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78641): https://edk2.groups.io/g/devel/message/78641 Mute This Topic: https://groups.io/mt/84344204/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
