Hi,

> -    if (ResStatus == EFI_RESOURCE_SATISFIED) {
> +    if ((ResStatus == EFI_RESOURCE_SATISFIED) ||
> +        (ResStatus == PCI_RESOURCE_PARTIAL))
> +    {

> +++ b/MdeModulePkg/Include/Library/PciResourceLib.h
> @@ -0,0 +1,20 @@
> +/** @file
> +  Pci resource library consumed by PciBusDxe and PciHostBridgeDxe drivers to
> +  share non-UEFI spec artefacts used in both drivers
> +
> +  Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> +
> +  This program and the accompanying materials
> +  are licensed and made available under the terms and conditions of the BSD 
> License
> +  which accompanies this distribution.  The full text of the license may be 
> found at
> +  http://opensource.org/licenses/bsd-license.php
> +
> +  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
> IMPLIED.
> + **/
> +#ifndef __PCI_RESOURCE_LIB_H__
> +#define __PCI_RESOURCE_LIB_H__
> +
> +#define PCI_RESOURCE_PARTIAL      0xFFFFFFFFFFFFFFFDULL
> +
> +#endif

Hmm, so you are hiding the #define here to avoid updating
Protocol/PciHostBridgeResourceAllocation.h ...

I suspect if this can't be implemented in the pci enumerator alone
there is just no way around actually extending uefi protocols.  But it's
also not fully clear to me why you need this new "partial" state.
Wouldn't you know either nothing or both base + size for a resource?

Also: Maybe split this series into two?  One for the host-provided
bridges, and another for the pre-populated bars?  So the former can
already be merged while the later is still sorted?

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86388): https://edk2.groups.io/g/devel/message/86388
Mute This Topic: https://groups.io/mt/88893097/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to