On 10/3/22 03:26, RichardHo [何明忠] via groups.io wrote:

diff --git a/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c 
b/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c
new file mode 100644
index 0000000000..5db95b284c
--- /dev/null
+++ b/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c

+/**
+  This function is called when UndiShutdown is invoked.
+
+  @param[in]  Cdb  A pointer to the command descriptor block.
+  @param[in]  Nic  A pointer to the Network interface controller data.
+
+  @retval EFI_SUCCESS     The request executed successfully.
+
+**/
+EFI_STATUS
+EFIAPI
+RndisUndiShutdown (
+  IN  PXE_CDB   *Cdb,
+  IN  NIC_DATA  *Nic
+  )
+{
+  EDKII_USB_ETHERNET_PROTOCOL  *UsbEthDriver   = Nic->UsbEth;
+  USB_RNDIS_DEVICE             *UsbRndisDevice = USB_RNDIS_DEVICE_FROM_THIS 
(UsbEthDriver);
+  REMOTE_NDIS_HALT_MSG         RndisHltMsg;
+  EFI_STATUS                   Status;
+
+  DEBUG ((DEBUG_INFO, "RndisUndiShutdown\n"));

According to the edk2 coding style, you should declare and initialize variables separately.

+/**
+ This is a dummy function which just returns. Unimplimented EDKII_USB_ETHERNET_PROTOCOL functions
+  point to this function.

Typo. Should be "Unimplemented".

diff --git a/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h b/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h
index 98eef820d895..9d607da72051 100644
--- a/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h
+++ b/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h

+#define USB_ETH_FRAME_SIZE             0x5F2  // frome network stack

Typo.




--
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96835): https://edk2.groups.io/g/devel/message/96835
Mute This Topic: https://groups.io/mt/94086820/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to