Hi Michael,

Thanks for your response. I will fixed it next.

Thanks,
Richard

-----Original Message-----
From: Michael Brown <[email protected]>
Sent: 2022年12月2日 6:09 PM
To: [email protected]; Richard Ho (何明忠) <[email protected]>
Cc: Andrew Fish <[email protected]>; Leif Lindholm <[email protected]>; 
Michael D Kinney <[email protected]>; Michael Kubacki 
<[email protected]>; Zhiguang Liu <[email protected]>; Liming 
Gao <[email protected]>; Tony Lo (羅金松) <[email protected]>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add 
USB RNDIS devices support


**CAUTION: The e-mail below is from an external source. Please exercise caution 
before opening attachments, clicking links, or following guidance.**

On 03/10/2022 10:26, RichardHo [何明忠] via groups.io wrote:
> diff --git a/UsbNetworkPkg/NetworkCommon/DriverBinding.h 
> b/UsbNetworkPkg/NetworkCommon/DriverBinding.h
> new file mode 100644
> index 0000000000..29f1f967f5
> --- /dev/null
> +++ b/UsbNetworkPkg/NetworkCommon/DriverBinding.h

> +VOID
> +UndiApiEntry (
> +  IN  UINT64  Cdb
> +  );

Needs an EFIAPI modifier, i.e.

VOID
EFIAPI
UndiApiEntry (
   IN  UINT64  Cdb
   );

to avoid runtime failures when using a non-Microsoft compiler.

> diff --git a/UsbNetworkPkg/NetworkCommon/PxeFunction.c 
> b/UsbNetworkPkg/NetworkCommon/PxeFunction.c
> new file mode 100644
> index 0000000000..f6505f7018
> --- /dev/null
> +++ b/UsbNetworkPkg/NetworkCommon/PxeFunction.c
> +/**
> +  UNDI API table entry.
> +
> +  @param[in]  Cdb  A pointer to the command descriptor block.
> +
> +**/
> +VOID
> +UndiApiEntry (
> +  IN  UINT64  Cdb
> +  )

As above:

VOID
EFIAPI
UndiApiEntry (
   IN  UINT64  Cdb
   )

Thanks,

Michael
-The information contained in this message may be confidential and proprietary 
to American Megatrends (AMI). This communication is intended to be read only by 
the individual or entity to whom it is addressed or by their designee. If the 
reader of this message is not the intended recipient, you are on notice that 
any distribution of this message, in any form, is strictly prohibited. Please 
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and 
then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96891): https://edk2.groups.io/g/devel/message/96891
Mute This Topic: https://groups.io/mt/94086820/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to