> Status = SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register,
> Width, Buffer);
> if (Status == EFI_UNSUPPORTED) {
> - Status = ReadSaveStateRegister (CpuIndex, Register, Width, Buffer);
> + Status = SmramSaveStateReadRegister (CpuIndex, Register, Width,
> Buffer);
> }
>
I would expect that above code unconditionally calls
SmramSaveStateReadRegister()
instead of having the Smram Save state access logic in either SmmCpuFeaturesLib
or in SmramSaveStateLib.
In open source project, you could directly call SmramSaveStateReadRegister()
because SmmCpuFeaturesReadSaveStateRegister()
in edk2 repo returns EFI_UNSUPPORTED.
I agree that close-source project which does something in
SmmCpuFeaturesReadSaveStateRegister() should update the implementation to
move the logic from SmmCpuFeaturesReadSaveStateRegister() to the new
close-source MmSaveStateLib instance.
We should explicitly mention the impact to these projects in commit messages.
Thanks,
Ray
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102817): https://edk2.groups.io/g/devel/message/102817
Mute This Topic: https://groups.io/mt/98172957/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
