Gerd, I am asking Abdul to directly call SaveStateLib from CpuSmm driver. I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver and SaveStateLib regarding the save state access.
Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd > Hoffmann > Sent: Tuesday, April 11, 2023 5:43 PM > To: Abdul Lateef Attar <abdat...@amd.com> > Cc: devel@edk2.groups.io; Abdul Lateef Attar > <abdullateef.at...@amd.com>; Paul Grimes <paul.gri...@amd.com>; > Garrett Kirkendall <garrett.kirkend...@amd.com>; Abner Chang > <abner.ch...@amd.com>; Dong, Eric <eric.d...@intel.com>; Ni, Ray > <ray...@intel.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>; Ard > Biesheuvel <ardb+tianoc...@kernel.org>; Yao, Jiewen > <jiewen....@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com> > Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses > SmmSmramSaveStateLib library > > > Uses new SmmSmramSaveStateLib library, > > which fix the CI failure. > > What is the exact failure you are seeing? > > > + > SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel > SmmSmramSaveStateLib.inf > > This should be the AMD version. KVM uses the AMD smram state. > > Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use > actually use the new SmmSmramSaveStateLib library, and once this > has been done it should be possible to remove > OvmfPkg/Include/Register/QemuSmramSaveStateMap.h > > take care, > Gerd > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102823): https://edk2.groups.io/g/devel/message/102823 Mute This Topic: https://groups.io/mt/98172964/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
