Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
This change can be merged first.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2023年4月24日 22:06
> 收件人: devel@edk2.groups.io; Liming Gao <gaolim...@byosoft.com.cn>;
> Bob Feng <bob.c.f...@intel.com>; Yuwei Chen <yuwei.c...@intel.com>
> 抄送: Rebecca Cran <rebe...@bsdio.com>
> 主题: [edk2-devel] [PATCH v2 1/1] BaseTools: Add quotes around OBJCOPY
> cmd in build_rule.template
>
> Add quotes around the OBJCOPY command in build_rule.template to fix the
> case where LLVM is installed on Windows in a path with spaces such as
> C:\Program Files\LLVM.
>
> Signed-off-by: Rebecca Cran <rebe...@bsdio.com>
> ---
> BaseTools/Conf/build_rule.template | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Conf/build_rule.template
> b/BaseTools/Conf/build_rule.template
> index d42e7937cc90..eb64c62060e1 100755
> --- a/BaseTools/Conf/build_rule.template
> +++ b/BaseTools/Conf/build_rule.template
> @@ -352,12 +352,12 @@
> -$(CP) $(DEBUG_DIR)(+)*.pdb $(OUTPUT_DIR)
> <Command.GCC>
> $(CP) ${src} $(DEBUG_DIR)(+)$(MODULE_NAME).debug
> - $(OBJCOPY) $(OBJCOPY_STRIPFLAG) ${src}
> + "$(OBJCOPY)" $(OBJCOPY_STRIPFLAG) ${src}
>
> #
> #The below 2 lines are only needed for UNIXGCC tool chain, which
> generates PE image directly
> #
> - -$(OBJCOPY) $(OBJCOPY_ADDDEBUGFLAG) ${src}
> + -"$(OBJCOPY)" $(OBJCOPY_ADDDEBUGFLAG) ${src}
> -$(CP) $(DEBUG_DIR)(+)$(MODULE_NAME).debug
> $(BIN_DIR)(+)$(MODULE_NAME_GUID).debug
>
> "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src}
> $(GENFW_FLAGS)
> --
> 2.40.0.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103499): https://edk2.groups.io/g/devel/message/103499
Mute This Topic: https://groups.io/mt/98483534/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
