Reviewed-by: Bob Feng <bob.c.f...@intel.com>
-----Original Message-----
From: Rebecca Cran <rebe...@bsdio.com>
Sent: Monday, April 24, 2023 10:06 PM
To: devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn>; Feng, Bob C
<bob.c.f...@intel.com>; Chen, Christine <yuwei.c...@intel.com>
Cc: Rebecca Cran <rebe...@bsdio.com>
Subject: [PATCH v2 1/1] BaseTools: Add quotes around OBJCOPY cmd in
build_rule.template
Add quotes around the OBJCOPY command in build_rule.template to fix the case
where LLVM is installed on Windows in a path with spaces such as C:\Program
Files\LLVM.
Signed-off-by: Rebecca Cran <rebe...@bsdio.com>
---
BaseTools/Conf/build_rule.template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Conf/build_rule.template
b/BaseTools/Conf/build_rule.template
index d42e7937cc90..eb64c62060e1 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -352,12 +352,12 @@
-$(CP) $(DEBUG_DIR)(+)*.pdb $(OUTPUT_DIR)
<Command.GCC>
$(CP) ${src} $(DEBUG_DIR)(+)$(MODULE_NAME).debug
- $(OBJCOPY) $(OBJCOPY_STRIPFLAG) ${src}
+ "$(OBJCOPY)" $(OBJCOPY_STRIPFLAG) ${src}
#
#The below 2 lines are only needed for UNIXGCC tool chain, which
generates PE image directly
#
- -$(OBJCOPY) $(OBJCOPY_ADDDEBUGFLAG) ${src}
+ -"$(OBJCOPY)" $(OBJCOPY_ADDDEBUGFLAG) ${src}
-$(CP) $(DEBUG_DIR)(+)$(MODULE_NAME).debug
$(BIN_DIR)(+)$(MODULE_NAME_GUID).debug
"$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS)
--
2.40.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103508): https://edk2.groups.io/g/devel/message/103508
Mute This Topic: https://groups.io/mt/98470825/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
