On Mon, Jun 12, 2023 at 09:37:18PM +0800, Yuanhao Xie wrote:
> Refactor the logic for placing APs in
> Mwait/Runloop into a separate function.
> + // If AP start-up signal is written, AP is waken up
> + // otherwise place AP in loop again
> + //
> + if ((*ApStartupSignalBuffer == WAKEUP_AP_SIGNAL) ||
> (*ApStartupSignalBuffer == MP_HAND_OFF_SIGNAL)) {
> + break;
> + }
> - // If AP start-up signal is written, AP is waken up
> - // otherwise place AP in loop again
> - //
> - if (*ApStartupSignalBuffer == WAKEUP_AP_SIGNAL) {
> - break;
> - }
Nope. This isn't refactoring. Please split the patch into two, one
doing the refactoring without functional change, and one adding the code
for MP_HAND_OFF_SIGNAL.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106216): https://edk2.groups.io/g/devel/message/106216
Mute This Topic: https://groups.io/mt/99483117/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
