Hi Gerd,
Thanks for the feedback.
I have updated in V2.
Please have a check.
Yuanhao
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd Hoffmann
Sent: Tuesday, June 20, 2023 10:11 PM
To: devel@edk2.groups.io; Xie, Yuanhao <yuanhao....@intel.com>
Cc: Dong, Eric <eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Kumar, Rahul
R <rahul.r.ku...@intel.com>
Subject: Re: [edk2-devel] [PATCH 3/5] UefiCpuPkg: Refactor the logic for
placing APs in Mwait/Runloop.
On Mon, Jun 12, 2023 at 09:37:18PM +0800, Yuanhao Xie wrote:
> Refactor the logic for placing APs in
> Mwait/Runloop into a separate function.
> + // If AP start-up signal is written, AP is waken up
> + // otherwise place AP in loop again
> + //
> + if ((*ApStartupSignalBuffer == WAKEUP_AP_SIGNAL) ||
> (*ApStartupSignalBuffer == MP_HAND_OFF_SIGNAL)) {
> + break;
> + }
> - // If AP start-up signal is written, AP is waken up
> - // otherwise place AP in loop again
> - //
> - if (*ApStartupSignalBuffer == WAKEUP_AP_SIGNAL) {
> - break;
> - }
Nope. This isn't refactoring. Please split the patch into two, one doing the
refactoring without functional change, and one adding the code for
MP_HAND_OFF_SIGNAL.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106330): https://edk2.groups.io/g/devel/message/106330
Mute This Topic: https://groups.io/mt/99483117/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
