Reviewed-by: Rebecca Cran <rebe...@bsdio.com> -- Rebecca Cran
On 11/6/2023 1:12 PM, Joey Vagedes wrote:
Clarify to users that they should review the build log when make (POSIX-like system) or nmake (Windows) fails to compile basetools. Cc: Rebecca Cran <rebe...@bsdio.com> Cc: Liming Gao <gaolim...@byosoft.com.cn> Cc: Bob Feng <bob.c.f...@intel.com> Cc: Yuwei Chen <yuwei.c...@intel.com> Signed-off-by: Joey Vagedes <joeyvage...@gmail.com> --- BaseTools/Edk2ToolsBuild.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Edk2ToolsBuild.py b/BaseTools/Edk2ToolsBuild.py index 425bb1b63963..4776c583080f 100644 --- a/BaseTools/Edk2ToolsBuild.py +++ b/BaseTools/Edk2ToolsBuild.py @@ -141,7 +141,9 @@ class Edk2ToolsBuild(BaseAbstractInvocable): for level, problem in problems: logging.log(level, problem) if ret != 0: - raise Exception("Failed to build.") + e = "Failed to run nmake.exe. Review Buildlog at BaseTools/BaseToolsBuild/BASETOOLS_BUILD.txt for nmake.exe error." + logging.error(e) + return retself.WritePathEnvFile(self.OutputDir)return ret @@ -156,7 +158,9 @@ class Edk2ToolsBuild(BaseAbstractInvocable): for level, problem in problems: logging.log(level, problem) if ret != 0: - raise Exception("Failed to build.") + e = "Failed to run make. Review Buildlog at BaseTools/BaseToolsBuild/BASETOOLS_BUILD.txt for make error." + logging.error(e) + return retself.OutputDir = os.path.join(shell_env.get_shell_var("EDK_TOOLS_PATH"), "Source", "C", "bin")
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110759): https://edk2.groups.io/g/devel/message/110759 Mute This Topic: https://groups.io/mt/102428862/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
