Series Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Joey > Vagedes via groups.io > Sent: Monday, November 6, 2023 12:12 PM > To: devel@edk2.groups.io > Cc: Rebecca Cran <rebe...@bsdio.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Feng, Bob C <bob.c.f...@intel.com>; Chen, > Christine <yuwei.c...@intel.com> > Subject: [edk2-devel] [PATCH v2 0/1] Edk2ToolsBuild.py: Clarify make > error > > When make or nmake fails to build the basetools, Edk2ToolsBuild.py > currently prints a generic error message "Failed to build." and > raises an exception. This has two issues: The first is that it raises > an exception, which leads people to believe it is a python issue, and > not a build issue. The second is that users don't necessarily know to > check the build log if this error occurs. > > This has been reported many times through many different avenues: > > https://github.com/tianocore/edk2/discussions/4611 > https://stackoverflow.com/questions/77421168/edkii-base-tools-fails- > to-build > https://github.com/tianocore/edk2-pytool-extensions/issues/180 > https://github.com/tianocore/edk2-pytool-extensions/issues/207 > > This patch series changes the exception to a error log so that the > invocable > completes and returns a non-zero exit code and also logs a more > descriptive > error that informs the user to review the build log, and where to find > it. > > Cc: Rebecca Cran <rebe...@bsdio.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Yuwei Chen <yuwei.c...@intel.com> > > Joey Vagedes (1): > BaseTools: Edk2ToolsBuild.py: Clarify make error > > BaseTools/Edk2ToolsBuild.py | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > -- > 2.34.1 > > º.¦È¨.)䱊.ç Š÷š– > Yž²Æ zË žÛh¶¬‚º.¥XžÃô^¦\ŽžX§{]tïž¡¶Úlÿ÷“h+¢êlŠàýׯz_æzËïõ×NùèËy8 > b±:)‰Èm¶›?þ > 躛"£ùÿ]6ão<ë_õëø÷¡«¢êNÂw«uëÞ—ê0êÞvM ®‹©²*žË›±Êâmèm¶›?ýçdÚ > 躛"£ø?uëÞ—û§²ææ‰ÈZzWdŠyÞÊ)ízW( -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110762): https://edk2.groups.io/g/devel/message/110762 Mute This Topic: https://groups.io/mt/102428861/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
