On 1/19/24 11:17, Ni, Ray wrote: > Chao, > > > > In the plan A, CpuDxe.inf contains reference to > gUefiCpuPkgTokenSpaceGuid.PcdCpuExceptionVectorBaseAddress in [Pcd] > section. But I guess it’s only needed by LoongArch64. That’s why I > didn’t like the common-inf idea. > > > > But after looking at the other INF changes, I changed my mind. I think > the common-inf looks good as the other INF files don’t have so much > difference between LoonArch and x86. > > > > So, I am ok with plan A. Thanks for preparing both changes for review. > > > > Mike, Laszlo, Gerd, Abner, any comments?
I'm also OK with plan A. Thanks Laszlo > > > > > > Thanks, > > Ray > > *From:* Chao Li <lic...@loongson.cn> > *Sent:* Thursday, January 18, 2024 4:27 PM > *To:* Ni, Ray <ray...@intel.com>; Sunil V L <suni...@ventanamicro.com> > *Cc:* devel@edk2.groups.io; Kinney, Michael D > <michael.d.kin...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Gerd > Hoffmann <kra...@redhat.com>; Abner Chang <abner.ch...@amd.com> > *Subject:* Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg > > > > Hi Ray and Sunil, > > Sorry, I'm late, I have very busy these days. > > I created two PRs in my private repo. > > *Plan A:* > > Moved most of LoongArch libraries and drivers to current matching > folders, removed LoongArch private INF, adjusted common INF. > > URL: https://github.com/kilaterlee/edk2/pull/8 > <https://github.com/kilaterlee/edk2/pull/8> > > > > *Plan B:* > > Moved most of LoongArch libraries and drivers to current matching > folders, keeping to use LoongArch private INF. > > URL: https://github.com/kilaterlee/edk2/pull/9 > <https://github.com/kilaterlee/edk2/pull/9> > > > > After you reading these two PRs, let's discuss how to deal with INF. > > I prefer plan A, it is better to use the same INF for all ARCHs and have > only one INF per modules. I was discussed this plan with Ray and Abner, > but it was not allowed at the time. > > > > Thanks, > Chao > > On 2024/1/16 08:59, Chao Li wrote: > > OK, let me finish this work tomorrow, I'm a little busy today. > > On 2024/1/15 16:11, Ni, Ray wrote: > > Yes. Fine to me. Thanks! > > > > Thanks, > > Ray > > -----Original Message----- > > From: Sunil V L <suni...@ventanamicro.com> > <mailto:suni...@ventanamicro.com> > > Sent: Monday, January 15, 2024 2:46 PM > > To: Chao Li <lic...@loongson.cn> <mailto:lic...@loongson.cn> > > Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ni, Ray > <ray...@intel.com> <mailto:ray...@intel.com>; Kinney, Michael D > > <michael.d.kin...@intel.com> <mailto:michael.d.kin...@intel.com>; > Laszlo Ersek <ler...@redhat.com> <mailto:ler...@redhat.com>; Gerd > > Hoffmann <kra...@redhat.com> <mailto:kra...@redhat.com> > > Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg > > > > On Mon, Jan 15, 2024 at 02:17:09PM +0800, Chao Li wrote: > > Ray and Sunil, > > > > I plan send two example PRs to github to show how to deal > the INFs, one to > > adjust current INF, and another PR to move the libraris to > the current > > folders. I hope after these two PRs are sent we can decide > what to do with > > the INF. What do you think of this plan? > > > > > > Hi Chao, That's fine with me. > > > > Thanks, > > Sunil > > Thanks, > > Chao > > On 2024/1/15 13:44, Ni, Ray wrote: > > That will be great! > > > > Thanks, > > Ray > > -----Original Message----- > > From: Sunil V L<suni...@ventanamicro.com> > <mailto:suni...@ventanamicro.com> > > Sent: Monday, January 15, 2024 12:44 PM > > To: Ni, Ray<ray...@intel.com> > <mailto:ray...@intel.com> > > Cc:devel@edk2.groups.io;lic...@loongson.cn > <mailto:Cc:devel@edk2.groups.io;lic...@loongson.cn>; Kinney, Michael D > > <michael.d.kin...@intel.com> > <mailto:michael.d.kin...@intel.com>; Laszlo Ersek<ler...@redhat.com> > <mailto:ler...@redhat.com>; Gerd > > Hoffmann<kra...@redhat.com> <mailto:kra...@redhat.com> > > Subject: Re: RFC: Folder layout change in UefiCpuPkg > > > > On Mon, Jan 15, 2024 at 01:13:03AM +0000, Ni, Ray > wrote: > > Sunil, > > I am glad that you don't have concern about the > direction. > > > > "RiscV" is good to me. > > > > > > Thanks!, Ray. So, shall I send patches to reorganize > this? > > > > Thanks, > > Sunil > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114046): https://edk2.groups.io/g/devel/message/114046 Mute This Topic: https://groups.io/mt/103679850/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
