On 15 October 2001, Nick Clarey wrote: > Matt, > > > I have again attatched my AT retry loging patch, which is small and > > simple. I ask that this be my first patch of the CVS. > > > > Once given access to the CVS tree, I will then undertake smsc_at3.c. > > > > Is this OK with the current maintainer group ? > > This patch doesn't do anything significant. Rework your at3 stuff into a > patch and we'll look at that. A three-liner that does nothing but print out > a few debug messages isn't sufficient, in my mind. > > See ya,
So Nick, Please point out to me then how the users of Kannel are meant to know that their message has failed due to retry failure, and specifically which message it was which failed. There is a group of users who use my system to send on average 1000 SMSs a day using the at_module. Since I got the at_module working close to 100% this was their biggest problem. They could see the retries count out and fail to send the SMS, but did not know which SMS it was which failed. It simply is not logged. On average you see this error about once for every 150 SMSs. Now for you to turn around and say that 'this is not significant enough' would make THEM vomit ! (I am not too particularly fussed) Before this patch they had to watch kannel to track the failed SMSs ... that takes about 3 hours or something like that. Would you like to be in their shoes ? I think not. IF YOU DO NOT WANT TO GIVE ME ACCESS THEN FINE, HOWEVER THIS PATCH IS NECESSARY. I suggest you patch the CVS tree and give me access WHEN YOU DEEM MY KNOWLEDGE, EXPERIENCE AND EFFORT WITH KANNEL SIGNIFICANT. OK ? -- Matt For electronic musicians ... Vector Bass : http://mffmvectorbass.sourceforge.net/ For developers ... 3D Audio Library : http://mffm3daudiolib.sourceforge.net/ Multimedia Time Code : http://mffmtimecode.sourceforge.net/
