I'm going to commit this unless someone complains
I've had one successfull user: From: Damjan <[EMAIL PROTECTED]> Ok, this patch works - I successfully compiled it and sent several overwriting messages with "pid=65". Thanks David. (Off to testing Kannel/SMPP further). -----Forwarded Message----- > From: Bruno David Simões Rodrigues <[EMAIL PROTECTED]> > To: Damjan <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED], Steffen Lindemann <[EMAIL PROTECTED]> > Subject: [PATCH] SMPP pid and dcs (Was: Re: overwrite a previous send SMS) > Date: 30 Apr 2002 02:23:36 +0100 > > It looks like smpp module lacks pid support. > > This is a patch hopefully to enable pid support (MO and MT) and > MO dcs support (setting mclass, coding, etc) > > As I don't have access to SMPP SMSC's neither I know smpp, > please someone test this and tell me if it works so I could commit, > or the SMPP people check, fix and commit themselves > > > Index: gw/smsc_smpp.c > =================================================================== > RCS file: /home/cvs/gateway/gw/smsc_smpp.c,v > retrieving revision 1.56 > diff -u -r1.56 smsc_smpp.c > --- gw/smsc_smpp.c 24 Apr 2002 08:13:36 -0000 1.56 > +++ gw/smsc_smpp.c 30 Apr 2002 01:21:02 -0000 > @@ -199,6 +199,8 @@ > msg->sms.msgdata = pdu->u.deliver_sm.short_message; > pdu->u.deliver_sm.short_message = NULL; > charset_gsm_to_latin1(msg->sms.msgdata); > + msg->sms.pid = pdu->u.deliver_sm.protocol_id; > + dcs_to_fields(&msg, pdu->u.deliver_sm.data_coding); > > return msg; > } > @@ -276,6 +278,8 @@ > } > > pdu->u.submit_sm.data_coding = fields_to_dcs(msg, 0); > + if(msg->sms.pid) > + pdu->u.submit_sm.protocol_id = msg->sms.pid; > > if (octstr_len(msg->sms.udhdata)) { > pdu->u.submit_sm.short_message = >