Hi list,

two commits from my side for today:

2006-02-23  Stipe Tolj  <stolj at kannel.org>
  * wap/wtp.c: fixing bug #310, causing wapbox to panic while gwlist_append()
    produces an assertion error if a malformed WTP datagram is tried to be
    processes and we try to send an RcvError PDU deducing the TID value from
    the WTP datagram, causing us to push the WAPEvent into a wrong list.

This was causing wapbox to panic on a high-loaded system. Now we're supposed to consider us immunic for bogus WTP data. We simply don't reply to the WTP initiator.

2006-02-23  Stipe Tolj  <stolj at kannel.org>
  * gwlib/octstr.[ch]: adding a more flexible octstr_dump() call via a variadic
    macro call. Allowing a third argument specifying the log-level of the
    Octstr dump. Ie. octstr_dump(ost, 0, GW_ERROR) will dump in ERROR log level.
    The variadic macro will allow the current usage without a third parameter
    and hence doesn't require mass patching of existing code. This more flexible
    octstr_dump() is intended to be used for higher log level runs, where we
    still want to dump particular data in case we run into warnings or errors.
    Running in debug log level for real-life production systems in order to get
    full data dumps is not suitable for a long period, so this allows a shorted
    log level with reduced log sizes, but octstr_dumps where we need.

This is a feature improvement. Actually I always hated the idea to have debug log-level active in order to get flow-through data via ocstr_dump() calls.

On high-load systems your debug log-level will run you out of disk space very fast. So this is an approach to let developers log octstr data in a higher log-level.

This was applied for the above WTP layer fixing directly ;)

Stipe

-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------


Reply via email to