[PATCH] Re: SMPP deliver_sm arrives before submit_sm_resp

[Ben Suffolk]

Hi Stipe,

I'm always willing to share any improvements, and I did actually send the first of the 2 patch files I spoke about below for review in Jan/ Feb 2007, where it got quite a few +1's but it never got committed, can;t remember why. Here is the thread with them in, doe snot seem to mention the reason for no commit though :- http://www.nabble.com/Multiple-SMSCs-and-a-DLR-group- td8655999.html#a8655999

Anyway, I've been using it now over a year, and not had any problems with it. This patch is the the group dlr patch to enable multiple smscs with different smsc-ids to be part of the same dlr-group. This solves the problem where the dlr comes back on a different connection from the one it was sent in on.

dlr_group_smsc.patch
Description: Binary data

The second patch to fix the dlr delay issue (in the email below), clearly contains the first patch as well since it was not committed to CVS. Clearly if the first patch gets committed the the second one can be recreated as a standalone one easily enough if required. This has also been running for over a year on my production system without any issues.

dlr_delay.patch
Description: Binary data

Regards

Ben



On 14 Mar 2008, at 00:09, Stipe Tolj wrote:

Ben Suffolk schrieb:

Dave,
I had this problem somewhile back myself (Oct 2006 ) :-

http://www.nabble.com/Interesting-issue-with-DLRs- td6851347.html#a6923001 Anyway, I wrote a patch and have had no problems since. There were 2 different issues, one is the one you suggest, where it can come in a lot later, the other was because of the 2 different threads that process the TX & RX. My patch fixes them both. Your more than welcome to the patch, but as I had already applied another patch I wrote to allow multiple SMSCs to be grouped (I had a situation where I had 3 SMSC connections, and the DLR could come back from a different on that I submitted to) you will either need to apply that patch as well, or fiddle a bit with it. The smsc dlr group thing was discussed here, the patch never got committed though for some reason :- http://www.nabble.com/Multiple-SMSCs-and-a-DLR-group- td8655999.html#a8655999 I think the reason I didn't submit the DLR delay fix patch was because the DLR group patch did not get committed, and I did not have time to take out the first patches bits to create the clean patch against CVS head.

Email me directly if you want the 2 patch files.

So everyone can benefit from your contribution.



Thanks,
Stipe

-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------

Ben, can you please do us all a favor and send a the patches as 'diff -u' format with [PATCH] as subject prefix to the 'devel' mailing list, so we can review and see how to commit to CVS. In any case, I'd like to move this topic to the 'devel' list, since its more related to there.