Hi Alejandro, Just had a brief look at the patch, looks all good in my opinion. Will be hard for the rest of us to test without a carrier who sends intermediate reports ;)
Tested it on my existing simulators and all works fine. Thanks, Donald 2009/5/15 Alejandro Guerrieri <[email protected]> > Hi, > > This patch adds support for intermediate notification DLR's on SMPP. > > According to the SMPP 3.4 spec. section 5.2.17, Intermediate Notifications > are enabled by setting the bit 5 (0x10) on the registered_delivery flag. To > do this (after applying this patch), you must add 32 to the dlr-mask and it > will set the bit on the submit_sm PDU's. > > The patch also fixes a small glitch on the sscanf dlr parsing. On my tests > with a major carrier on the US, it turned out that the value for the "err:" > field could be hex-encoded (Alex: I know I shouldn't mix stuff, but this one > was just a line: @@ -1269,7 +1272,7 @@) > > I'm writing the userguide docs if this is accepted, as usual ;) > > Regards, > -- > Alejandro Guerrieri > [email protected] > > -- Donald Jackson http://www.ddj.co.za/ donaldjster(a)gmail.com
