| Alex, I'm attaching a new patch with indentation similar to it's neighboring lines and also the naming conventions fixed. Userguide mod is there as well. I don't know about other people, but for us it makes a lot of sense to be able to know the whereabouts of a message while in transit. I've tested it with a major US carrier and works perfectly. BTW, without this patch, if kannel happens to receive an intermediate notification, it'll recognize it as an MO, not a DLR Regarding the indentation, please check smsbox.c and dlr.h for example, you'll notice there's a lot of indenting problems and mix of tabs and spaces all over the place. For example: dlr.h Lines 69-76: #define<tab>DLR_XXXXX<spaces>0xXX Lines 78-89: #define<space>DLR_IS_XXXXX(dlr)<spaces>(DLR_IS..... smsbox.c, all the code is a mix of tabs and spaces, for example the validation code on lines 2228-2231: <4 spaces>if ( dlr_mask < -1 || dlr_mask > 32 ) { /* 00011111 */ <tab>returnerror = octstr_create("DLR-Mask field misformed, rejected"); <tab>goto field_error; <4 spaces>} I've used all spaces before, I'm not sure what's the proper way here, my new patch uses the same approach as it's neighboring lines, though it's not consistent across the file. Regards, |
kannel-dlr-intermediate.patch
Description: Binary data
On 15/05/2009, at 9:26, Alexander Malysh wrote:
|
