Hi Nikos,
I don't think that blocking DLRs in bearerbox when no dlr-url given is the
right thing todo.
- rc = route_incoming_to_boxc(copy);
+ if (sms->sms.sms_type != report_mo || octstr_len(sms->sms.dlr_url))
+ rc = route_incoming_to_boxc(copy);
+ else {
+ msg_destroy(copy);
+ rc = 1;
+ }
What will happens when another box as smsbox is connected to bearerbox and want
to receive all DLRs
independent whether dlr-url set or not?
I think this should be handled in smsbox...
Thanks,
Alexander Malysh
Am 14.11.2009 um 12:06 schrieb Nikos Balkanas:
> Sorry, better use this patch. cvs diff problem again.
>
> Nikos
> ----- Original Message -----
> From: Nikos Balkanas
> To: Alexander Malysh
> Cc: [email protected]
> Sent: Saturday, November 14, 2009 12:59 PM
> Subject: Re: Patch: wap_push_ppg.c
>
> Hi,
>
> My intention was just to align PPG with SMS push, which sets them
> independently. SMS push will attempt to get null URL and print an error about
> it, so I have fixed that, too.
>
> Furthermore, with this patch, if you are just logging dlrs & not using
> dlr_url for ppg, not only you don't need a web server, but also you don't
> need smsbox (assuming you use wapbox for ppg).
>
> BR,
> Nikos
> ----- Original Message -----
> From: Alexander Malysh
> To: Nikos Balkanas
> Cc: [email protected]
> Sent: Wednesday, November 11, 2009 6:58 PM
> Subject: Re: Patch: wap_push_ppg.c
>
> Hi Nikos,
>
> what will happen when DLR without dlr-url arrive in smsbox? can smsbox handle
> this?
>
> IMO it's good idea to allow DLRs without dlr-url but then make it consistent
> and change not only
> wap-push part but sms part as well...
>
> -1 for non consistent patch, ++1 for consistent.
>
> Thanks,
> Alexander Malysh
>
> Am 02.11.2009 um 16:21 schrieb Nikos Balkanas:
>
>> Hi,
>>
>> Another trivial patch for wap. The code disables dlrs, if no dlr_url is
>> specified, despite if dlr_mask is set. These are 2 different variables, and
>> I don't see why they should be linked like that. I just want the DLR in my
>> access logs, don't need the URL. I shouldn't have to setup a web server just
>> to get the DLR from the SMSc.
>>
>> BR,
>> Nikos
>> <wap_push_ppg.diff>
>
> <kannel.diff>
