I'd add a "default" query, so if you don't need it it would work just as it is now, but if you need to modify it it would be just a matter of adding the configuration parameters.
We could also add an example with your time-aware query on the configuration file. Regards, -- Alejandro Guerrieri [email protected] On 02/06/2010, at 12:06, Rene Kluwen wrote: > You have a valid point there. Even two of them : ). > Maybe, if there has to be an extra configuration parameter, your suggestion > makes sense and better make the whole SQL query configurable. > > What do the others think about it? > > =+= Rene > > From: [email protected] [mailto:[email protected]] > Sent: woensdag 2 juni 2010 10:50 > To: Rene Kluwen; 'Emmanuel CHANSON' > Cc: Kannel Devel > Subject: Re: Sqlbox and scheduled pushes > > If you don't need the scheduling, the query would be heavier and would break > backward-compatibility. > BlackBerry de movistar, allí donde estés está tu oficin@ > > From: "Rene Kluwen" <[email protected]> > Date: Wed, 2 Jun 2010 10:47:53 +0200 > To: <[email protected]>; 'Emmanuel > CHANSON'<[email protected]> > Cc: 'Kannel Devel'<[email protected]> > Subject: RE: Sqlbox and scheduled pushes > > Do we really need a configuration parameter? Just a question. > > From: [email protected] [mailto:[email protected]] > Sent: woensdag 2 juni 2010 10:07 > To: Rene Kluwen; 'Emmanuel CHANSON' > Cc: Kannel Devel > Subject: Re: Sqlbox and scheduled pushes > > Hey, I've told Emmanuel already, I don't claim the copyright ;) > > I agree on adding it as is, we only need to add it to all db engines and put > a configuration parameter to enable it. > > Regards, > > Alex > BlackBerry de movistar, allí donde estés está tu oficin@ > > From: "Rene Kluwen" <[email protected]> > Date: Wed, 2 Jun 2010 09:08:44 +0200 > To: 'Emmanuel CHANSON'<[email protected]> > Cc: 'Alejandro Guerrieri'<[email protected]>; <[email protected]> > Subject: RE: Sqlbox and scheduled pushes > > *smile* I am having a deja-vu. I sent this patch to Alex to begin with. Heh… > > @Emmanuel: I agree with you and will suggest this on your behalf to the devel > mailinglist. > > @devel: Alex suggested to make this even more configurable by putting the > SELECT query in kannel.conf (/sqlbox.conf). > However, I think this gives that much extra flexibility (and maintaining > backward compatibility) that this quick patch can be incorporated already. > It is useful for a lot of persons and it is just a quick patch. > > Todo: also patch the sql statements for other storage types. > > Rene Kluwen > Chimit > > > > From: Emmanuel CHANSON [mailto:[email protected]] > Sent: woensdag 2 juni 2010 2:46 > To: [email protected] > Cc: Alejandro Guerrieri > Subject: Re: Sqlbox and scheduled pushes > > Hello Rene I had sent my email to a wrong person... > > Emmanuel > > 2010/5/31 Emmanuel CHANSON <[email protected]> > Hello Rene, > > I would like to tell you about sqlbox and a requirement I have done on sqlbox > source advised by Alex :) > My need was to be able to send a scheduled batch using sqlbox. > Alex told me first that sqlbox could not and I have to do this from the > application but after a while he advised me to try to patch the source like > this: > > in gw/sqlbox_mysql.h > something like: > SELECT sql_id, momt, sender, receiver, udhdata, \ > msgdata, time, smsc_id, service, account, id, sms_type, mclass, mwi, coding, \ > compress, validity, deferred, dlr_mask, dlr_url, pid, alt_dcs, rpi, \ > charset, boxc_id, binfo, meta_data FROM %S WHERE time < UNIX_TIMESTAMP(NOW()) > LIMIT 0,1" > > That is what I have done and it seems to work like a charm :) > So I wonder if this can not be proposed to others because it is something > very usefull...for me at least.. > > Regards, > > Emmanuel > > > > -- > Emmanuel > > CHANSON Emmanuel > Mobile Nouvelle-Calédonie: +687.77.35.02 > Mobile France: +33 (0) 6.68.03.89.56 > @email : [email protected] > > > > -- > Emmanuel > > CHANSON Emmanuel > Mobile Nouvelle-Calédonie: +687.77.35.02 > Mobile France: +33 (0) 6.68.03.89.56 > @email : [email protected]
