Hi Rene, Many thanks for the explanation. But for me, setting 2 as default and or fixed value during INSERT is the cleanest way and surely will avoid the panic condition rather than during the table creation. A little patch on sqlbox_mysql.c and well this is only my personal approach.
On Sep 17, 2013, at 11:56 PM, Rene Kluwen <[email protected]> wrote: > Agreed with Stipe here. > If the users enters a different value for sms_type, it is their > responsibility. > > What is covered here, is an accidental wrong value for sms_type, because > nowhere is documented that sms_type should be set to MT (value '2') because > otherwise Kannel will panic. > > Attached is a simple solution that will benefit everyone. Which is ready to > be committed. > > == Rene > > -----Original Message----- > From: devel [mailto:[email protected]] On Behalf Of Stipe Tolj > Sent: dinsdag 17 september 2013 17:55 > Cc: kannel_dev_mailinglist devel@kannel. org > Subject: Re: [PATCH] No PANIC on failing store_load() > > Am 17.09.2013 17:22, schrieb Willy Mularto: >> Sorry, it doesn't mean setting default value during table creation >> right? Because this approach will still might be interupted by user's >> value. Thanks. > > The default value is defined during table creation, yes. The point is: > IF the user doesn't insert a specific value for the field THEN the default > is applied. If the user specifically inserts -1 then he will get -1. But > that makes no logical sense. > > Stipe > > -- > ------------------------------------------------------------------- > Kölner Landstrasse 419 > 40589 Düsseldorf, NRW, Germany > > tolj.org system architecture Kannel Software Foundation (KSF) > http://www.tolj.org/ http://www.kannel.org/ > > mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org > ------------------------------------------------------------------- > > <default.diff>
