2013/9/18 spameden <[email protected]>:
> I think first edit @ 20th line is not needed.
>
> @@ -7,7 +7,7 @@
> momt ENUM('MO', 'MT', 'DLR') NULL, sender VARCHAR(20) NULL, \
> receiver VARCHAR(20) NULL, udhdata BLOB NULL, msgdata TEXT NULL, \
> time BIGINT(20) NULL, smsc_id VARCHAR(255) NULL, service VARCHAR(255) NULL, \
> -account VARCHAR(255) NULL, id BIGINT(20) NULL, sms_type BIGINT(20) NULL, \
> +account VARCHAR(255) NULL, id BIGINT(20) NULL, sms_type BIGINT(20)
> NOT NULL DEFAULT 2, \
> mclass BIGINT(20) NULL, mwi BIGINT(20) NULL, coding BIGINT(20) NULL, \
> compress BIGINT(20) NULL, validity BIGINT(20) NULL, deferred BIGINT(20)
> NULL, \
> dlr_mask BIGINT(20) NULL, dlr_url VARCHAR(255) NULL, pid BIGINT(20) NULL, \
>
> because it edits definition of sent_sms table, but you need only
> send_sms, because records inserted there (which is a 2nd edit -
> #define SQLBOX_MYSQL_CREATE_INSERT_TABLE ...)
I'm sorry in first sentence I've said first edit @ 20 is not needed,
but actually I meant first edit @ 7th line.
So the correct patch would look like (for only send_sms table):
--- sqlbox_mysql.h 2013-09-18 00:01:37.000000000 +0400
+++ sqlbox_mysql.h.edit 2013-09-18 00:02:30.000000000 +0400
@@ -20,7 +20,7 @@
momt ENUM('MO', 'MT') NULL, sender VARCHAR(20) NULL, \
receiver VARCHAR(20) NULL, udhdata BLOB NULL, msgdata TEXT NULL, \
time BIGINT(20) NULL, smsc_id VARCHAR(255) NULL, service VARCHAR(255) NULL, \
-account VARCHAR(255) NULL, id BIGINT(20) NULL, sms_type BIGINT(20) NULL, \
+account VARCHAR(255) NULL, id BIGINT(20) NULL, sms_type BIGINT(20)
NULL DEFAULT 2, \
mclass BIGINT(20) NULL, mwi BIGINT(20) NULL, coding BIGINT(20) NULL, \
compress BIGINT(20) NULL, validity BIGINT(20) NULL, deferred BIGINT(20) NULL, \
dlr_mask BIGINT(20) NULL, dlr_url VARCHAR(255) NULL, pid BIGINT(20) NULL, \
>
> 2013/9/17 Stipe Tolj <[email protected]>:
>> Am 17.09.2013 18:56, schrieb Rene Kluwen:
>>>
>>> Agreed with Stipe here.
>>> If the users enters a different value for sms_type, it is their
>>> responsibility.
>>>
>>> What is covered here, is an accidental wrong value for sms_type, because
>>> nowhere is documented that sms_type should be set to MT (value '2')
>>> because
>>> otherwise Kannel will panic.
>>>
>>> Attached is a simple solution that will benefit everyone. Which is ready
>>> to
>>> be committed.
>>
>>
>> +1 from me. What about the direction implication? Is this table only for the
>> MT direction?
>>
>> For an MO table we may have an other value for sms_type here.
>>
>> Stipe
>>
>> --
>> -------------------------------------------------------------------
>> Kölner Landstrasse 419
>> 40589 Düsseldorf, NRW, Germany
>>
>> tolj.org system architecture Kannel Software Foundation (KSF)
>> http://www.tolj.org/ http://www.kannel.org/
>>
>> mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org
>> -------------------------------------------------------------------
>>
