Greg, Any updates? Please ... Please find some time to have a look at it!!
Alan, Please have a look at it too. I've dealt with most of the comments, device context has been provided, spin-locks have been reviewed and documented multiple devices also can be easily supported if required. > -----Original Message----- > From: Savoy, Pavan > Sent: Monday, September 13, 2010 5:02 PM > To: [email protected]; [email protected] > Cc: [email protected]; [email protected] > Subject: RE: [PATCH] drivers:staging:ti-st: fix kim platform device id > > Greg, > > > ---------------- > Thanks & Regards, > Pavan Savoy | x0099669 > > > -----Original Message----- > > From: Savoy, Pavan > > Sent: Friday, September 10, 2010 2:59 PM > > To: [email protected]; [email protected] > > Cc: [email protected]; [email protected]; Savoy, Pavan > > Subject: [PATCH] drivers:staging:ti-st: fix kim platform device id > > > > From: Pavan Savoy <[email protected]> > > > > Platform devices tend to have id as -1 when only 1 device exist and > > a value >=0 when multiple devices exist, since we plan to store all > > these platform devices if multiple exist, there was a requirement to > > have id to be >=0. > > The patch fixes this problem. > > Please merge this patch, and I hope you find some time to review the rest of > them. > > > > Signed-off-by: Pavan Savoy <[email protected]> > > --- > > drivers/staging/ti-st/st_kim.c | 9 ++++++++- > > 1 files changed, 8 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/staging/ti-st/st_kim.c b/drivers/staging/ti-st/st_kim.c > > index 9e99463..be18c7a 100644 > > --- a/drivers/staging/ti-st/st_kim.c > > +++ b/drivers/staging/ti-st/st_kim.c > > @@ -638,7 +638,14 @@ static int kim_probe(struct platform_device *pdev) > > long *gpios = pdev->dev.platform_data; > > struct kim_data_s *kim_gdata; > > > > - st_kim_devices[pdev->id] = pdev; > > + if ((pdev->id != -1) && (pdev->id < MAX_ST_DEVICES)) { > > + /* multiple devices could exist */ > > + st_kim_devices[pdev->id] = pdev; > > + } else { > > + /* platform's sure about existance of 1 device */ > > + st_kim_devices[0] = pdev; > > + } > > + > > kim_gdata = kzalloc(sizeof(struct kim_data_s), GFP_ATOMIC); > > if (!kim_gdata) { > > pr_err("no mem to allocate"); > > -- > > 1.6.5 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
