On 11/10/2010 02:20 PM, Damian Varayud wrote:
> @@ -291,21 +296,22 @@ static void __exit ni_tio_cleanup_module(void)
>
> module_exit(ni_tio_cleanup_module);
>
> struct ni_gpct_device *ni_gpct_device_construct(struct comedi_device *dev,
> - void (*write_register) (struct
> - ni_gpct
> - *
> - counter,
> - unsigned
> - bits,
> - enum
> -
> ni_gpct_register
> - reg),
> - unsigned (*read_register)
> - (struct ni_gpct *counter,
> - enum ni_gpct_register reg),
> - enum ni_gpct_variant variant,
> - unsigned num_counters)
> + void (*write_register)
> + (struct ni_gpct *counter,
> + unsigned bits,
> + enum ni_gpct_register reg),
> + unsigned (*read_register)
> + (struct ni_gpct *counter,
> + enum ni_gpct_register reg),
> + enum ni_gpct_variant variant,
> + unsigned num_counters)
I don't think this looks anyhow saner. What about shifting it left like:
void (*write_register)(struct ni_gpct *counter,
unsigned bits, enum ni_gpct_register reg),
unsigned (*read_register)(struct ni_gpct *counter,
enum ni_gpct_register reg),
enum ni_gpct_variant variant, unsigned num_counters)
regards,
--
js
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
