Removed inactive code sections (BCM_DMAPAD and CHIPC_UART_ALWAYS_ON
were never defined). Also replaced magic number by #define. Deleted
incorrect comment.

Signed-off-by: Roland Vossen <[email protected]>
Reviewed-by: Arend van Spriel <[email protected]>
---
 drivers/staging/brcm80211/brcmsmac/wl_mac80211.c |    5 +++--
 drivers/staging/brcm80211/util/bcmutils.c        |    1 -
 drivers/staging/brcm80211/util/hnddma.c          |    4 ----
 drivers/staging/brcm80211/util/hndpmu.c          |    7 -------
 4 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c 
b/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c
index ef88fef..add9ac8 100644
--- a/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c
+++ b/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c
@@ -48,6 +48,8 @@
 #include "wl_ucode.h"
 #include "wl_mac80211.h"
 
+#define N_TX_QUEUES    4 /* #tx queues on mac80211<->driver interface */
+
 static void wl_timer(unsigned long data);
 static void _wl_timer(struct wl_timer *t);
 
@@ -1076,8 +1078,7 @@ static int ieee_hw_init(struct ieee80211_hw *hw)
            | IEEE80211_HW_AMPDU_AGGREGATION;
 
        hw->extra_tx_headroom = wlc_get_header_len();
-       /* FIXME: should get this from wlc->machwcap */
-       hw->queues = 4;
+       hw->queues = N_TX_QUEUES;
        /* FIXME: this doesn't seem to be used properly in minstrel_ht.
         * mac80211/status.c:ieee80211_tx_status() checks this value,
         * but mac80211/rc80211_minstrel_ht.c:minstrel_ht_get_rate()
diff --git a/drivers/staging/brcm80211/util/bcmutils.c 
b/drivers/staging/brcm80211/util/bcmutils.c
index 003ecce..fb0bccc 100644
--- a/drivers/staging/brcm80211/util/bcmutils.c
+++ b/drivers/staging/brcm80211/util/bcmutils.c
@@ -257,7 +257,6 @@ void pktq_flush(struct pktq *pq, bool dir)
        ASSERT(pq->len == 0);
 }
 #else /* !BRCM_FULLMAC */
-/* TODO: can we remove callback for softmac? */
 void
 pktq_pflush(struct pktq *pq, int prec, bool dir,
            ifpkt_cb_t fn, int arg)
diff --git a/drivers/staging/brcm80211/util/hnddma.c 
b/drivers/staging/brcm80211/util/hnddma.c
index 9362f56..59e4470 100644
--- a/drivers/staging/brcm80211/util/hnddma.c
+++ b/drivers/staging/brcm80211/util/hnddma.c
@@ -1455,10 +1455,6 @@ static int BCMFASTPATH dma64_txfast(dma_info_t *di, 
struct sk_buff *p0,
 
                data = p->data;
                len = p->len;
-#ifdef BCM_DMAPAD
-               /* TODO: when is this used? */
-               len += PKTDMAPAD(di->osh, p);
-#endif                         /* BCM_DMAPAD */
                next = p->next;
 
                /* return nonzero if out of tx descriptors */
diff --git a/drivers/staging/brcm80211/util/hndpmu.c 
b/drivers/staging/brcm80211/util/hndpmu.c
index ba1b590..9e9cfc9 100644
--- a/drivers/staging/brcm80211/util/hndpmu.c
+++ b/drivers/staging/brcm80211/util/hndpmu.c
@@ -34,7 +34,6 @@
 
 /* debug-only definitions */
 /* #define BCMDBG_FORCEHT */
-/* #define CHIPC_UART_ALWAYS_ON */
 #else
 #define        PMU_MSG(args)
 #endif                         /* BCMDBG */
@@ -2513,12 +2512,6 @@ void si_pmu_chip_init(si_t *sih)
 
        ASSERT(sih->cccaps & CC_CAP_PMU);
 
-#ifdef CHIPC_UART_ALWAYS_ON
-       /* TODO: are these special for debugging purposes? */
-       si_corereg(sih, SI_CC_IDX, offsetof(chipcregs_t, clk_ctl_st),
-                  CCS_FORCEALP, CCS_FORCEALP);
-#endif                         /* CHIPC_UART_ALWAYS_ON */
-
        /* Gate off SPROM clock and chip select signals */
        si_pmu_sprom_enable(sih, false);
 
-- 
1.7.1


_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to