This patch fixes up a printk warning found by the checkpatch.tool. Convert printk to dev_<levels>. Removes useless printk messages.
Signed-off-by: Ravishankar Karkala Mallikarjunayya <[email protected]> --- drivers/staging/comedi/drivers/dt2801.c | 21 ++++++++------------- 1 files changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt2801.c b/drivers/staging/comedi/drivers/dt2801.c index 5cce1b5..9433712 100644 --- a/drivers/staging/comedi/drivers/dt2801.c +++ b/drivers/staging/comedi/drivers/dt2801.c @@ -389,7 +389,8 @@ static int dt2801_writecmd(struct comedi_device *dev, int command) ("dt2801: composite-error in dt2801_writecmd(), ignoring\n"); } if (!(stat & DT_S_READY)) - printk("dt2801: !ready in dt2801_writecmd(), ignoring\n"); + printk + ("dt2801: !ready in dt2801_writecmd(), ignoring\n"); outb_p(command, dev->iobase + DT2801_CMD); return 0; @@ -424,7 +425,7 @@ static int dt2801_reset(struct comedi_device *dev) break; } while (timeout--); if (!timeout) - printk("dt2801: timeout 1 status=0x%02x\n", stat); + dev_dbg(dev->hw_dev, "dt2801: timeout 1 status=0x%02x\n", stat); /* printk("dt2801: reading dummy\n"); */ /* dt2801_readdata(dev,&board_code); */ @@ -441,7 +442,7 @@ static int dt2801_reset(struct comedi_device *dev) break; } while (timeout--); if (!timeout) - printk("dt2801: timeout 2 status=0x%02x\n", stat); + dev_dbg(dev->hw_dev, "dt2801: timeout 2 status=0x%02x\n", stat); DPRINTK("dt2801: reading code\n"); dt2801_readdata(dev, &board_code); @@ -539,17 +540,11 @@ static int dt2801_attach(struct comedi_device *dev, struct comedi_devconfig *it) if (boardtypes[type].boardcode == board_code) goto havetype; } - printk("dt2801: unrecognized board code=0x%02x, contact author\n", - board_code); type = 0; havetype: dev->board_ptr = boardtypes + type; - printk("dt2801: %s at port 0x%lx", boardtype.name, iobase); - n_ai_chans = probe_number_of_ai_chans(dev); - printk(" (ai channels = %d)", n_ai_chans); - ret = alloc_subdevices(dev, 4); if (ret < 0) goto out; @@ -610,7 +605,6 @@ havetype: ret = 0; out: - printk("\n"); return ret; } @@ -627,12 +621,13 @@ static int dt2801_error(struct comedi_device *dev, int stat) { if (stat < 0) { if (stat == -ETIME) - printk("dt2801: timeout\n"); + dev_err(dev->hw_dev, "dt2801: timeout\n"); else - printk("dt2801: error %d\n", stat); + dev_err(dev->hw_dev, "dt2801: error %d\n", stat); return stat; } - printk("dt2801: error status 0x%02x, resetting...\n", stat); + dev_err(dev->hw_dev, "dt2801: error status 0x%02x, resetting...\n", + stat); dt2801_reset(dev); dt2801_reset(dev); -- 1.7.0.4 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
