Do some minimal error checking of the parameters of
`comedi_auto_config()`.  Just make sure the `hardware_device` and
`driver` parameters are non-NULL.

Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
 drivers/staging/comedi/drivers.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 4724f27..4460814 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -410,6 +410,16 @@ int comedi_auto_config(struct device *hardware_device,
        struct comedi_device *comedi_dev;
        int ret;
 
+       if (!hardware_device) {
+               pr_warn("BUG! comedi_auto_config called with NULL 
hardware_device\n");
+               return -EINVAL;
+       }
+       if (!driver) {
+               dev_warn(hardware_device,
+                        "BUG! comedi_auto_config called with NULL comedi 
driver\n");
+               return -EINVAL;
+       }
+
        if (!driver->auto_attach) {
                dev_warn(hardware_device,
                         "BUG! comedi driver '%s' has no auto_attach handler\n",
-- 
1.8.1.5

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to