On Fri, Apr 05, 2013 at 11:35:11AM +0100, Ian Abbott wrote:
> On 2013/04/04 08:24 PM, Dan Carpenter wrote:
> > On Thu, Apr 04, 2013 at 02:58:42PM +0100, Ian Abbott wrote:
> >> diff --git a/drivers/staging/comedi/drivers.c
> >> b/drivers/staging/comedi/drivers.c
> >> index 4724f27..4460814 100644
> >> --- a/drivers/staging/comedi/drivers.c
> >> +++ b/drivers/staging/comedi/drivers.c
> >> @@ -410,6 +410,16 @@ int comedi_auto_config(struct device *hardware_device,
> >> struct comedi_device *comedi_dev;
> >> int ret;
> >>
> >> + if (!hardware_device) {
> >> + pr_warn("BUG! comedi_auto_config called with NULL
> >> hardware_device\n");
> >
> >
> > WARN() would give you a nice stack trace for easy debugging.
>
> I could do. It should be a fairly obvious bug if it occurs though. It
> could maybe output the driver name as long as the driver parameter is
> not NULL (assuming it really is pointing to a valid struct comedi_driver!).
>
It's not a big deal either way. Your choice. It's something that
could be changed in a later patch anyway.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
