> On 14 Nov 2016, at 13:25, Peter Robinson <pbrobin...@gmail.com> wrote:
> 
> On Mon, Nov 14, 2016 at 1:23 PM, Peter Robinson <pbrobin...@gmail.com> wrote:
>>>>> On 11/10/2016 09:42 PM, Barry Scott wrote:
>>>>> In this bug
>>>>> 
>>>>>   https://bugzilla.redhat.com/show_bug.cgi?id=1360797
>>>>> 
>>>>> It is implied that rpkg has an unspecified problem with GitPython 2.0.
>>>>> 
>>>>> This is preventing the maintainer from updating to the any GitPython 2
>>>>> release.
>>>>> 
>>>>> I'd like to know if there is in fact a problem with rpkg with GitPython 
>>>>> 2.0.
>>>>> 
>>>> 
>>>> Import error here.
>>>> 
>>>> File "/root/code/rpkg/pyrpkg/__init__.py", line 14, in <module>
>>>>   import git
>>>> File "/root/rpkg-env/lib/python2.6/site-packages/git/__init__.py", line 
>>>> 38, in <module>
>>>>   from git.config import GitConfigParser  # @NoMove @IgnorePep8
>>>> File "/root/rpkg-env/lib/python2.6/site-packages/git/config.py", line 25, 
>>>> in <module>
>>>>   from git.util import LockFile
>>>> File "/root/rpkg-env/lib/python2.6/site-packages/git/util.py", line 18, in 
>>>> <module>
>>>>   from unittest.case import SkipTest
>>>> ImportError: No module named case
>>>> 
>>>> GitPython >= 2 cannot work with Python 2.6 at all.
>>> 
>>> So on a system where you want to use rpkg with python 2.6 use GitPython 1.
>>> 
>>> But that is no reason to stop updating GitPython 2 for Fedora 24 where 
>>> python 2.7
>>> Is used for rpkg right?
> 
> Take 2.
> 
> If the API is the same between the releases I don't see why it
> wouldn't be OK, presumably the reason why is has been held at that
> older version is that the API isn't compatible and would need someone
> to do a patch for rpkg to support both versions/APIs and I suspect
> that is that people haven't had the resource (time or otherwise) to do
> that.

My exprience with contribting to GitPython is tha backward compatibility was 
very important for any improvement.

I was hoping to find out if there is in fact a patch to rpkg is required.

Barry

> 
> Peter
> _______________________________________________
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Reply via email to