On Tue, Dec 6, 2016 at 10:22 PM, Kevin Kofler <kevin.kof...@chello.at> wrote:
> Adam Williamson wrote:
>> Dennis has untagged this from Rawhide for now, as it broke ARM disk
>> image composes.
>
> That is probably Neal's fix to make -foo actually exclude foo from the
> compose. That is required to make -foo work with weak dependencies, i.e.,
> for when something Recommends: foo or when foo Supplements something. (We
> will also be submitting a similar fix to Anaconda/livemedia-creator.)
> Unfortunately, it is a behavior change for when foo is actually Required by
> something else in the compose: That now produces an error instead of
> silently including foo anyway. We think, however, that this is the right
> thing to do (it does not make sense to have -foo in the kickstart just to
> have the compose tool include foo behind your back anyway), but existing
> live-kickstarts do need fixing to remove bogus exclusions.

It was not that. It was because appliance-tools has a broken import
for python-imgcreate, and doesn't even properly pull it in.

Also, appliance-tools itself doesn't require python-imgcreate, so now
that livecd-tools uses python3 by default, it can't import anything
anyway.

Two simple fixes, attached to this email.



-- 
真実はいつも一つ!/ Always, there's only one truth!
--- appliance-tools.spec~       2016-12-06 19:46:22.000000000 -0500
+++ appliance-tools.spec        2016-12-06 19:50:11.496865709 -0500
@@ -5,7 +5,7 @@
 Summary: Tools for building Appliances
 Name: appliance-tools
 Version: 007.8
-Release: 10%{?dist}
+Release: 11%{?dist}
 License: GPLv2
 Group: System Environment/Base
 URL: https://git.fedorahosted.org/git/appliance-tools.git
@@ -19,8 +19,10 @@ URL: https://git.fedorahosted.org/git/ap
 Source0: appliance-tools-%{version}.tar.bz2
 Patch0: appliance-tools-nss.hack
 Patch1: appliance-tools-partitioning-fixes.patch
+Patch2: 0001-Fix-import-for-compatibility-with-livecd-tools-v24.patch
 
-Requires: livecd-tools >= 020 curl rsync kpartx
+Requires: python-imgcreate >= 24.0
+Requires: curl rsync kpartx
 Requires: zlib
 Requires: qemu-img
 Requires: xz
@@ -40,6 +42,7 @@ derived distributions such as RHEL, Cent
 %setup -q
 %patch0 -p1
 %patch1 -p1
+%patch2 -p1
 
 %build
 make
@@ -67,6 +70,10 @@ rm -rf $RPM_BUILD_ROOT
 %{python_sitelib}/ec2convert/*.pyc
 
 %changelog
+* Tue Dec 06 2016 Neal Gompa <ngomp...@gmail.com> 007.8-11
+- Change dependency from livecd-tools to python-imgcreate
+- Fix for python-imgcreate v24 compatibility
+
 * Tue Sep 20 2016 Peter Robinson <pbrobin...@fedoraproject.org> 007.8-10
 - Fix swap partition type creation
 - Set boot partition as bootable

Attachment: 0001-Fix-import-for-compatibility-with-livecd-tools-v24.patch
Description: Binary data

_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Reply via email to