On 01/06/2017 01:59 PM, Thomas Moschny wrote:
2017-01-05 14:01 GMT+01:00 Florian Weimer <fwei...@redhat.com>:
On 01/05/2017 11:58 AM, Michael Schwendt wrote:
On Thu, 5 Jan 2017 00:58:00 +0000, Richard W.M. Jones wrote:
It would also be nice if:
PYTHON=/usr/bin/python3 %configure
didn't (silently) do the wrong thing by default. For a long time we
shipped a nbdkit-python3 package which was using python2, and that was
found to be the cause.
And the configure script didn't accept the external definition of $PYTHON,
I guess. What could the %configure macro do about it?
If you look at "rpm -E %configure", anything it does wouldn't help, if
the parameters are ignore or don't make it into the Makefiles.
I suspect the problem is that the PYTHON=… setting is only applied to the
first shell command in the %configure expansion. It's not the configure
invocation, just a plain variable assignment, so PYTHON is set, but not
exported to subprocesses (such as the future invocation of ./configure).
There is probably some shell hackery we could use to avoid that, but I don't
think more magic should be the goal.
Wouldn't it suffice to put PYTHON= at the end? autotools' configure
scripts accept such assignments (and even remember them in
config.status etc).
Indeed, this looks like a reasonable solution.
Thanks,
Florian
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
