On 16/02/17 10:15 +0000, Jonathan Wakely wrote:
On 15/02/17 22:53 -0500, Orcan Ogetbil wrote:
On 15 February 2017 at 09:12, Jonathan Wakely wrote:
A mockchain build of dbus-c++ libffado and sflphone works with this
patch. repoquery says nothing else depends on dbus-c++.

Any objections to me committing the patch to dbus-c++ and rebuilding it?

Somebody should also fork dbus-c++ to fix or remove this junk.

Hi Jonathan,
Thank you for taking a look at this. I am fine with the patch. A less
intrusive solution would be to disable the #ifndef block between lines
232-235. But I am okay either way.

Let's do this the right way. I submitted a ticket on the project's
sourceforge tracker and I attached your patch.

Please feel free to apply your patch (adding a comment with a link to
the upstream ticket) and rebuild. We can update the package later if
upstream decides to act on it.

Will do, thanks for reporting it upstream.

I was wrong about the packages building with that patch. I was
confused by the fact that mockchain doesn't stop building if one
package in the chain fails, which makes it pretty useless.

libffado has more of these stupid errors that have affected dozens of
packages because [expletives deleted]:

src/libieee1394/configrom.cpp: In member function 'bool 
src/libieee1394/configrom.cpp:179:31: error: ISO C++ forbids comparison between 
pointer and integer [-fpermissive]
    while ((buf + len - 1) == '\0') {
src/libieee1394/configrom.cpp:198:31: error: ISO C++ forbids comparison between 
pointer and integer [-fpermissive]
    while ((buf + len - 1) == '\0') {

That should probably be dereferencing (buf + len -1)

And sflphone fails to configure now with some GnuTLS error, which
should be fixed by gnutls-3.5.9-2.fc26

devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Reply via email to